Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Option<> for 'db_log_dir' config #960

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Use Option<> for 'db_log_dir' config #960

merged 1 commit into from
Nov 28, 2023
+19 −15

Conversation

romanz
Copy link
Owner

@romanz romanz commented Nov 27, 2023

Following #959 (comment)

@romanz romanz mentioned this pull request Nov 27, 2023
Merged
@romanz romanz force-pushed the optional-db-log-dir branch 2 times, most recently from 80913a1 to 24f2024 Compare November 27, 2023 20:55
Kixunil
Kixunil approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks great!

@romanz romanz force-pushed the optional-db-log-dir branch from 24f2024 to 4f76c63 Compare November 28, 2023 18:13
@romanz romanz merged commit 4f76c63 into master Nov 28, 2023
8 checks passed
@romanz romanz deleted the optional-db-log-dir branch November 28, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanz @Kixunil