Allow setting RocksDB log directory #959
Merged
+59
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
reviewed
Nov 26, 2023
| name = "db_log_dir" | ||
| type = "std::path::PathBuf" | ||
| doc = "Directory to store index database internal log (default: same as specified by `db_dir`)" | ||
| default = "\"\".into()" |
There was a problem hiding this comment.
I think it'd look better if we just made it optional ans only set it if it's Some. I'm surprised setting an empty even does the right thing.
There was a problem hiding this comment.
I'm surprised setting an empty even does the right thing.
I agree, but it seems to work:
https://github.com/facebook/rocksdb/blob/f6fd4b9dbd15dba36f7e5ad23de407b5c26b1460/db/db_impl/db_impl_files.cc#L246
BTW, does configure_me support Optional<PathBuf>?
There was a problem hiding this comment.
Yes, simply leave out default = "" and the type in the struct will be wrapped in Option. (For mandatory param you write optional = false.)
There was a problem hiding this comment.
Thanks! Please take a look at #960.
romanz
added a commit
that referenced
this pull request
Nov 27, 2023
romanz
added a commit
that referenced
this pull request
Nov 27, 2023
romanz
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #680 (comment).