deps/icu: Be more specific about what lib.exe we're looking for #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlinden
force-pushed
the
deps-icu
branch
from
d7a65ba to
6813fb2
Compare
This shaves 5-10 minutes off of the GitHub Actions build time for run_pkgdata_windows.
robinlinden
force-pushed
the
deps-icu
branch
from
6813fb2 to
7650574
Compare
Zer0-One
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shaves 5-10 minutes off of the GitHub Actions build time for
run_pkgdata_windows.
After: https://github.com/robinlinden/hastur/actions/runs/7175346860
Before: https://github.com/robinlinden/hastur/actions/runs/7066894570
I did add some debug prints to verify that this was the pattern we were getting, so this is just a faster way of finding the same
lib.exe.