Skip to content

Commit

Permalink
deps/icu: Be more specific about what lib.exe we're looking for
Browse files Browse the repository at this point in the history
This shaves 5-10 minutes off of the GitHub Actions build time for
run_pkgdata_windows.
  • Loading branch information
robinlinden committed Dec 12, 2023
1 parent 7755f81 commit 7650574
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion third_party/icu.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ genrule(
outs = ["sicudt73l.lib"],
cmd = r"""
srcs=($(SRCS));
export PATH=$$PATH:$(location icupkg):"/$$('C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' -latest -prerelease -find '**\lib.exe' | grep x64 | grep -v llvm | head -n1 | awk -F '\' 'BEGIN{OFS=FS} {$$NF=""; print}' | tr -d ':' | tr '\134' '/')";
export PATH=$$PATH:$(location icupkg):"/$$('C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' -latest -prerelease -find 'VC\Tools\MSVC\*\bin\Hostx64\x64\lib.exe' | grep -v llvm | head -n1 | awk -F '\' 'BEGIN{OFS=FS} {$$NF=""; print}' | tr -d ':' | tr '\134' '/')";
$(location pkgdata) --entrypoint icudt73 --sourcedir $(RULEDIR) --destdir $(RULEDIR) --name icudt73l --mode static $${srcs[0]}
""",
tools = [
Expand Down

0 comments on commit 7650574

Please sign in to comment.