-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [DO NOT MERGE] introduce libcugraph wheels #4804
Draft
jameslamb
wants to merge
53
commits into
rapidsai:branch-25.02
Choose a base branch
from
jameslamb:libcugraph-wheel
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
/ok to test |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
In #4804, I've started working on adding `libcugraph` wheels. This includes a few fixes for things I noticed while doing that: * removes `wget` from `test_notebook` environment - *our CI images already have this system-installed, and removing it helps to remove it from the environment solve for the unified RAPIDS devcontainers* * `dependencies.yaml` re-organization: - breaks `librmm` dependency out into a `depends_on_librmm` to reduce duplication, and for consistency with other RAPIDS dependencies - uses `depends_on_pylibwholegraph` group everywhere instead of repeating `pylibwholegraph` in multiple places - removes unused YAML anchors - alphabetizes lists ## Notes for Reviewers I'd originally wanted to also add a `librmm` wheel dependency for wheel builds here, but looks like doing that resulted in a lot more `sccache` misses, I guess because of building with build isolation. That change will happen in #4804 . Authors: - James Lamb (https://github.com/jameslamb) - Ralph Liu (https://github.com/nv-rliu) Approvers: - Bradley Dice (https://github.com/bdice) URL: #4805
jameslamb
changed the title
WIP: introduce libcugraph wheels
WIP: [DO NOT MERGE] introduce libcugraph wheels
Dec 30, 2024
/ok to test |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…anges (#4847) Proposes some changes to small things I noticed while working on #4804. * CMake option cleanup: - adds `BUILD_PRIMS_BENCH OFF`, removes `BUILD_BENCH OFF` in `get_raft.cmake` (matching changes to RAFT from 23.04: rapidsai/raft#1304) - adds `BUILD_BENCHMARKS OFF` in `get_cudf.cmake` ([this is the default](https://github.com/rapidsai/cudf/blob/b81d9e17fbffbb912e0128148f556bf7af41b6ab/cpp/CMakeLists.txt#L51), but better to be explicit) * consolidates some `.gitignore` rules, adds wheels and conda packages there * moves responsibility for installing CI artifacts into `ci/test_wheel_{package}.sh` and out of `ci/test_wheel.sh` * splits up Cython and `scikit-build-core` in `dependencies.yaml` - *every Python package here using Cython also uses `scikit-build-core`, but the reverse won't be true as of #4804 ... making that change here is harmless and reduces the size of the diff in #4804 a bit* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #4847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4340, contributes to rapidsai/build-planning#33.
Blocked by rapidsai/raft#2531
Proposes packaging
libcugraph
as a wheel, which is then re-used bycugraph-cu{11,12}
andpylibcugraph-cu{11,12}
wheels.Notes for Reviewers
If you see this note, that means this is not ready for review.
Dependency Flows
Size changes (CUDA 12, Python 3.12, x86_64)
libcugraph
pylibcugraph
cugraph
NOTES: size = compressed, "before" = 2024-12-06 nightlies (5c8f850)
how I calculated those (click me)