-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move wheel installs into per-project test scripts, other packaging changes #4847
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
put it back up for review after pushing 6776530 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one quick request for .gitignore
/merge |
Proposes some changes to small things I noticed while working on #4804.
BUILD_PRIMS_BENCH OFF
, removesBUILD_BENCH OFF
inget_raft.cmake
(matching changes to RAFT from 23.04: Add end-to-end CUDA ann-benchmarks to raft raft#1304)BUILD_BENCHMARKS OFF
inget_cudf.cmake
(this is the default, but better to be explicit).gitignore
rules, adds wheels and conda packages thereci/test_wheel_{package}.sh
and out ofci/test_wheel.sh
scikit-build-core
independencies.yaml
scikit-build-core
, but the reverse won't be true as of WIP: [DO NOT MERGE] introduce libcugraph wheels #4804 ... making that change here is harmless and reduces the size of the diff in WIP: [DO NOT MERGE] introduce libcugraph wheels #4804 a bit