Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move wheel installs into per-project test scripts, other packaging changes #4847

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 6, 2025

Proposes some changes to small things I noticed while working on #4804.

Copy link

copy-pr-bot bot commented Jan 6, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2025
@jameslamb jameslamb changed the title WIP: use RAPIDS_VERSION in CMake CPM scripts, other packaging changes WIP: move wheel installs into per-project test scripts, other packaging changes Jan 7, 2025
@jameslamb jameslamb changed the title WIP: move wheel installs into per-project test scripts, other packaging changes move wheel installs into per-project test scripts, other packaging changes Jan 8, 2025
@jameslamb jameslamb marked this pull request as ready for review January 8, 2025 15:12
@jameslamb jameslamb requested review from a team as code owners January 8, 2025 15:12
@jameslamb jameslamb requested a review from AyodeAwe January 8, 2025 15:12
@jameslamb
Copy link
Member Author

jameslamb commented Jan 8, 2025

Since this hasn't been reviewed yet... gonna move it back to draft and cancel CI. There are some more small changes I'd like to include here.

put it back up for review after pushing 6776530

@jameslamb jameslamb marked this pull request as draft January 8, 2025 17:53
@jameslamb jameslamb changed the title move wheel installs into per-project test scripts, other packaging changes WIP: move wheel installs into per-project test scripts, other packaging changes Jan 8, 2025
@jameslamb jameslamb removed the request for review from AyodeAwe January 8, 2025 17:53
@jameslamb jameslamb marked this pull request as ready for review January 8, 2025 18:01
@jameslamb jameslamb requested a review from a team as a code owner January 8, 2025 18:01
@jameslamb jameslamb requested a review from AyodeAwe January 8, 2025 18:01
@jameslamb jameslamb changed the title WIP: move wheel installs into per-project test scripts, other packaging changes move wheel installs into per-project test scripts, other packaging changes Jan 8, 2025
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one quick request for .gitignore

.gitignore Outdated Show resolved Hide resolved
@jameslamb jameslamb removed the request for review from AyodeAwe January 9, 2025 15:28
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a6eea2f into rapidsai:branch-25.02 Jan 9, 2025
74 checks passed
@jameslamb jameslamb deleted the misc-packaging branch January 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants