Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "weird" comments in duplicate_argument_linter() #2404

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2402, split off from #2393 for clarity

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d47f7c) 98.68% compared to head (e819ce9) 98.68%.

❗ Current head e819ce9 differs from pull request most recent head a1e05dd. Consider uploading reports for the commit a1e05dd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         126      126           
  Lines        5698     5700    +2     
=======================================
+ Hits         5623     5625    +2     
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR AshesITR merged commit 50d17ae into main Dec 8, 2023
20 checks passed
@AshesITR AshesITR deleted the dup-comment branch December 8, 2023 05:45
@AshesITR AshesITR restored the dup-comment branch December 8, 2023 05:50
@AshesITR AshesITR deleted the dup-comment branch December 8, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate_argument_linter() thrown off by a well-placed comment within the call
3 participants