Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata tests for all linters #2393

Merged
merged 39 commits into from
Dec 8, 2023
Merged

Add metadata tests for all linters #2393

merged 39 commits into from
Dec 8, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Dec 5, 2023 •
edited
Loading

Closes #2221

@MichaelChirico MichaelChirico marked this pull request as draft December 5, 2023 06:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50d17ae) 98.68% compared to head (098231c) 98.68%.

❗ Current head 098231c differs from pull request most recent head dd57ec5. Consider uploading reports for the commit dd57ec5 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2393   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         126      126           
  Lines        5700     5700           
=======================================
  Hits         5625     5625           
  Misses         75       75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico changed the title Attempt to get GHA going Add metadata tests for all linters Dec 5, 2023
IndrajeetPatil
IndrajeetPatil reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! 😊

I am glad we are automating this check. One less comment for @AshesITR to leave in his PR reviews 😜

.dev/lint_metadata_test.R Show resolved Hide resolved
@MichaelChirico
Copy link
Collaborator Author

OK, parking it here for now until #2385 is merged to avoid a huge git conflict

@MichaelChirico MichaelChirico mentioned this pull request Dec 6, 2023
Closed
IndrajeetPatil
IndrajeetPatil previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks but overall this looks fantastic! Thanks a lot for the thorough clean-up of the test suite.

@IndrajeetPatil IndrajeetPatil added internals Issues related to inner workings of lintr, i.e., not user-visible testing lint-metadata labels Dec 7, 2023
@AshesITR AshesITR deleted the branch main December 8, 2023 05:45
@AshesITR AshesITR closed this Dec 8, 2023
@MichaelChirico
Copy link
Collaborator Author

(assuming the wrong button pressed here)

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 8, 2023

Yikes, the merge of dup-comment into main auto-closed this PR... Sorry.
Can you change the target of this to main? I can't...

@MichaelChirico
Copy link
Collaborator Author

that's weird, usually it auto-updates to main. I also don't see the usual way to edit the merge target.mm

@AshesITR AshesITR reopened this Dec 8, 2023
@AshesITR AshesITR changed the base branch from dup-comment to main December 8, 2023 05:51
@AshesITR AshesITR dismissed IndrajeetPatil’s stale review December 8, 2023 05:51

The base branch was changed.

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 8, 2023

Ah it seems I was too fast hitting the Delete Button.
Restoring dup-comments, then reopening here added the edit option back. Sorry for the confusion.

AshesITR
AshesITR reviewed Dec 8, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

AshesITR commented Dec 8, 2023

Nice work. Basically LGTM.

IndrajeetPatil
IndrajeetPatil previously approved these changes Dec 8, 2023
View reviewed changes
@AshesITR
Copy link
Collaborator

AshesITR commented Dec 8, 2023

Waiting for feedback on my comment before merging.

@IndrajeetPatil
Copy link
Collaborator

Yepp, no hurry. I just wanted to confirm that my comments above have been addressed and ready for a merge from my end.

@IndrajeetPatil IndrajeetPatil merged commit 8029e1f into main Dec 8, 2023
21 checks passed
@IndrajeetPatil IndrajeetPatil deleted the ensure-metadata branch December 8, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

@IndrajeetPatil IndrajeetPatil IndrajeetPatil left review comments

Assignees
No one assigned
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible lint-metadata testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ensure some metadata tests for all linters
4 participants
@MichaelChirico @codecov-commenter @AshesITR @IndrajeetPatil