Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method calling with caching globally disabled #212 #227

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cachier/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,11 @@ def func_wrapper(*args, **kwds):
if verbose:
_print = print
if ignore_cache or not _default_params["caching_enabled"]:
return func(**kwargs)
return (
func(args[0], **kwargs)
if core.func_is_method
else func(**kwargs)
)
key, entry = core.get_entry((), kwargs)
if overwrite_cache:
return _calc_entry(core, key, func, args, kwds)
Expand Down
70 changes: 70 additions & 0 deletions tests/test_general.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,76 @@ def get_random():
assert result_1 != result_3


def test_global_disable_function():
@cachier.cachier()
def test():
return True

cachier.disable_caching()
try:
assert test()
finally:
cachier.enable_caching()


def test_global_disable_method():
class Test:
@cachier.cachier()
def test(self):
return True

cachier.disable_caching()
try:
assert Test().test()
finally:
cachier.enable_caching()


def test_global_disable_method_with_args():
class Test:
@cachier.cachier()
def test(self, test):
return test

cachier.disable_caching()
try:
assert Test().test(1) == 1
finally:
cachier.enable_caching()


def test_global_disable_method_with_optional_parameters():
class Test:
def __init__(self, val):
self.val = val

@cachier.cachier()
def test(self, test=0):
return self.val + test

cachier.disable_caching()
try:
assert Test(1).test(test=1) == 2
finally:
cachier.enable_caching()


def test_global_disable_method_with_args_and_optional_parameters():
class Test:
def __init__(self, val):
self.val = val

@cachier.cachier()
def test(self, test1, test2=0):
return self.val + test1 + test2

cachier.disable_caching()
try:
assert Test(1).test(2, 3) == 6
finally:
cachier.enable_caching()


def test_none_not_cached_by_default():
count = 0

Expand Down
Loading