Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method calling with caching globally disabled #212 #227

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix method calling with caching globally disabled #212 #227

merged 1 commit into from
Aug 5, 2024

Conversation

dphi
Copy link
Contributor

@dphi dphi commented Aug 4, 2024

Hi, this PR addresses #212 .

Thanks for reviewing.

@dphi dphi requested a review from shaypal5 as a code owner August 4, 2024 13:33
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (2a4d1c9) to head (43b2dc3).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   97.84%   97.97%   +0.13%     
==========================================
  Files           8       10       +2     
  Lines         511      544      +33     
  Branches       88       94       +6     
==========================================
+ Hits          500      533      +33     
  Misses         10       10              
  Partials        1        1              
Flag Coverage Δ
db 63.60% <100.00%> (?)
local 89.88% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/cachier/core.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6efd2e...43b2dc3. Read the comment docs.

@shaypal5
Copy link
Collaborator

shaypal5 commented Aug 4, 2024

OMG, awesome PR. Thanks! :)

The only thing left to fix is making the ruff check pass on the pre-commit.ci.

Here's the output:

Ruff check...............................................................Failed
- hook id: ruff
- exit code: 1

warning: `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible. Ignoring `one-blank-line-before-class`.
warning: `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible. Ignoring `multi-line-summary-second-line`.
tests/test_general.py:251:16: E712 Avoid equality comparisons to `True`; use `if test():` for truth checks
    |
249 |     cachier.disable_caching()
250 |     try:
251 |         assert test() == True
    |                ^^^^^^^^^^^^^^ E712
252 |     finally:
253 |         cachier.enable_caching()
    |
    = help: Replace with `test()`

tests/test_general.py:264:16: E712 Avoid equality comparisons to `True`; use `if Test().test():` for truth checks
    |
262 |     cachier.disable_caching()
263 |     try:
264 |         assert Test().test() == True
    |                ^^^^^^^^^^^^^^^^^^^^^ E712
265 |     finally:
266 |         cachier.enable_caching()
    |
    = help: Replace with `Test().test()`

Found 2 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

@dphi dphi temporarily deployed to safety_check August 5, 2024 08:40 — with GitHub Actions Inactive
@shaypal5 shaypal5 merged commit 5db1b45 into python-cachier:master Aug 5, 2024
35 checks passed
@shaypal5
Copy link
Collaborator

shaypal5 commented Aug 5, 2024

Released in v3.0.1.

@shaypal5 shaypal5 added the bug label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants