Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch #557

NitinBhasneria · 2020-07-11T15:21:52Z

Fixes

Repoint woofmark to pull in fixes from latest https://github.com/jywarren/woofmark/
Popup Disappearing problem solved by @NitinBhasneria Popup Disappearing problem solved jywarren/woofmark#3
Feature to change heading back into plain text by @shreyaa-sharmaa Feature to change heading back into plain text jywarren/woofmark#5
Refine drag and drop events to prevent interference by @NitinBhasneria Refine drag and drop events to prevent interference with other drag/drop-sensitive fields in downstream use cases jywarren/woofmark#2
Setup jest-puppeteer for UI tests by @Shulammite-Aso setup jest-puppeteer for UI test jywarren/woofmark#11
Added custom insert module by @keshav234156 Added Custom Insert Module #568
Made history icons consistent in demo editor fixes by @Shulammite-Aso Make history icons consistent in demo editor #571
Main image box padding and background by @NitinBhasneria Main image box padding and background #564
ADDS: Feature to decenter text in wysiwyg and markdown mode by @Shreyaa-s ADDS: Feature to decenter text in wysiwyg and markdown mode #521
Remove file button test added by @NitinBhasneria Added remove file test #574
Adds puppeteer as a dev dependency by @Shreyaa-s Adds puppeteer as a dev dependency #565
Add support for class attribute in links by @Shulammite-Aso Add support for class attribute in links #547
Update dependencies in plots2 branch by @Shulammite-Aso Update dependencies in plots2 branch jywarren/woofmark#17
fix bold texts loosing formatting after converting to markdown and back to wysiwyg by @Shulammite-Aso fix bold texts loosing formatting after converting to markdown and back to wysiwyg jywarren/woofmark#15
Compact Design for main Image Module by @shreyaa-sharmaa Compact Design for main Image Module #594

After publiclab/plots2#8285 merges, we can publish this!

jywarren · 2020-07-11T15:26:33Z

Hi @NitinBhasneria do you think we could try resolving #553 and #475 to try to make reviewing these releases easier, before publishing this one?

NitinBhasneria · 2020-07-11T15:28:52Z

Hi @NitinBhasneria do you think we could try resolving #553 and #475 to try to make reviewing these releases easier, before publishing this one?

Yea, this would be great.

jywarren · 2020-07-14T13:59:27Z

Ok! I think our checklist for this is now:

resolve the issues we're seeing in Bump publiclab-editor from 2.0.6 to 2.1.0 plots2#8135
be sure we open a new PR to pull in the latest jywarren/woofmark once that's ready

However, I think we can push off the second list item to v2.1.2 if it slows us down. Thanks! Who is taking up the issues in publiclab/plots2#8135? @NitinBhasneria @shreyaa-sharmaa @keshav234156 @Shulammite-Aso

Great work, folks!

gitpod-io · 2020-07-14T14:01:27Z

keshav234156 · 2020-07-14T15:23:26Z

@jywarren can we also add #519 in this release?

jywarren · 2020-07-14T15:28:42Z

@keshav234156 i think so; but let's make the top priority fixing the bugs introduced in v2.1.0 -- thank you!

jywarren · 2020-07-14T17:33:09Z

#519 is now merged into main! So, let's add it to the release notes above. Thanks!

jywarren · 2020-07-21T18:50:25Z

Let's include #521 !

jywarren · 2020-07-21T19:26:47Z

#564 is also merged now!

jywarren · 2020-07-28T19:56:50Z

Hi @publiclab/editor folks! How are we doing here? We need to prioritize this in order to publish our first release, and won't that feel great!?

Can you check in on the blocking issues related to my comment above? Thank you so much!

cc @sagarpreet-chadha

keshav234156 · 2020-07-28T20:00:57Z

ok @jywarren having a look at this.

jywarren · 2020-08-11T14:55:28Z

Hi @NitinBhasneria - so after merging #587 I merged #588 which bumped the NPM version. Let's change this one to v2.1.2 as it contains the switch over to the plots2 woofmark branch. Then let's release this ASAP. Thanks a ton!

jywarren · 2020-08-11T14:57:16Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "publiclab-editor",
-  "version": "2.1.1",
+  "version": "2.1.2",


OK! And once this merges, can you create a new Release with the release notes here? I think we need to add a few more updates from https://github.com/publiclab/PublicLab.Editor/pulse/monthly as well to summarize other changes from folks. @publiclab/editor who else has had changes merged? Can we include #568 @keshav234156 ?

yes, we can include the #568.
Also, I have updated the list have a look.

sagarpreet-chadha · 2020-08-11T16:46:41Z

Very exciting 🎉
cc @NitinBhasneria @keshav234156 @shreyaa-sharmaa @Shulammite-Aso , make sure you add your changes here so Nitin can make the release note 💯

sagarpreet-chadha

@NitinBhasneria can you run npm install by checking into this branch? There should be changes in package-lock.json also I believe.

NitinBhasneria · 2020-08-11T16:50:38Z

@NitinBhasneria can you run npm install by checking into this branch? There should be changes in package-lock.json also I believe.

yea, sure.

cypherean · 2020-08-11T17:00:57Z

Looks good!! 🎉 🎉

sagarpreet-chadha · 2020-08-11T17:30:32Z

package-lock.json

@@ -13298,10 +13301,11 @@
      "dev": true
    },
    "woofmark": {
-      "version": "git://github.com/jywarren/woofmark.git#12e2c1d4559268e2de605ad6084d5dce24ea42c6",
+      "version": "git://github.com/jywarren/woofmark.git#39237b798308e6855acde1a938c18a8e4da62fce",


Only this should had changed, everything else should be same.

See this https://stackoverflow.com/questions/44297803/what-is-the-role-of-the-package-lock-json#:~:text=the%20npm%20docs%3A-,package-lock.,regardless%20of%20intermediate%20

jywarren · 2020-08-11T18:43:37Z

Hi all, thanks! Looks like tests failed, could it be due to the woofmark changes?

jywarren · 2020-08-11T18:45:13Z

Huh. The error is: https://travis-ci.com/github/publiclab/PublicLab.Editor/jobs/370789599#L211

I'll restart it but is there any possibility of an issue in woofmark?

npm ERR! Unexpected string in JSON at position 516656

jywarren · 2020-08-11T18:47:43Z

And noting we had forgotten to build dist files in v2.1.1 so we had to release v2.1.2 here: publiclab/plots2#8286

So this now becomes v2.1.3 -- thanks!!!

Shulammite-Aso · 2020-08-12T11:19:19Z

Hi all, i think these should be added here too:
fix bold&emphasized texts loosing formatting after converting to markdown and back to wysiwyg jywarren/woofmark#15
Update dependencies in plots2 branch jywarren/woofmark#17
Add support for class attribute in links #547

jywarren · 2020-08-12T17:02:46Z

Resolved a conflict in package-lock.json - can folks confirm that this is correct by testing it in GitPod? Thanks!

jywarren · 2020-08-12T17:26:31Z

Ah, let's resolve this critical main image upload bug first, then this should be good for final approval and publication! #593

jywarren · 2020-08-12T17:27:59Z

As well as this formatting issue to try to get the main image module a little more compact - that would be really awesome! #592 -- any volunteers?

jywarren · 2020-08-12T19:20:47Z

Having tested #593 in gitpod, it seems to work there. Can anyone else confirm this locally, installed on plots2? I think that may mean we are OK to move forward with this release, although I'd love it if someone stepped up to do a little refining in #592 first. Thank you!

jywarren · 2020-08-13T15:35:47Z

Thanks @shreyaa-sharmaa for submitting this PR for the button styling!!! #594 Awesome, almost there!!

jywarren · 2020-08-14T19:14:45Z

Hi all! With Compact Design for main Image Module #594 by @shreyaa-sharmaa, we are ready to publish this!!!! 🎉 🎉 🎉 🎉

jywarren · 2020-08-14T19:16:27Z

I'm going to merge this and publish it! 🎉 🎉 🎉 🎉 🎉

jywarren · 2020-08-14T19:22:08Z

Technically upon review this would be a minor version number bump of v2.2.0 according to semantic versioning! So, I'm going to bump it up one more time to that, then release.

jywarren · 2020-08-14T19:28:57Z

Hooray!!!

https://github.com/publiclab/PublicLab.Editor/releases/tag/v2.2.0

https://www.npmjs.com/package/publiclab-editor

jywarren · 2020-08-14T19:46:17Z

And running plots2 tests here! publiclab/plots2#8297

Bump Version from 2.1.0 to 2.1.1

55a70a3

NitinBhasneria mentioned this pull request Jul 11, 2020

PLE v2.1.0 release #555

Merged

5 tasks

cypherean mentioned this pull request Jul 13, 2020

Heading Test #545

Open

5 tasks

Merge branch 'main' into bumpVersion2.1.1

d4b0586

jywarren mentioned this pull request Jul 14, 2020

Weekly Community Check-In #67 Books/Podcasts/Movies that you draw Inspiration from publiclab/plots2#8143

Closed

jywarren added the release label Jul 14, 2020

Merge branch 'main' into bumpVersion2.1.1

ce55a6d

Merge branch 'main' into bumpVersion2.1.1

ec28a21

Merge branch 'main' into bumpVersion2.1.1

f861ad5

Merge branch 'main' into bumpVersion2.1.1

b7b1f5b

jywarren changed the title ~~Bump Version from 2.1.0 to 2.1.1~~ Bump Version from 2.1.0 to 2.1.1, switch to woofmark plots2 branch Aug 11, 2020

jywarren changed the title ~~Bump Version from 2.1.0 to 2.1.1, switch to woofmark plots2 branch~~ Bump Version from 2.1.1 to 2.1.2, switch to woofmark plots2 branch Aug 11, 2020

v2.1.2

1330aca

jywarren reviewed Aug 11, 2020

View reviewed changes

Merge branch 'main' into bumpVersion2.1.1

d753ddd

jywarren requested review from keshav234156, cypherean and Shulammite-Aso August 11, 2020 15:02

sagarpreet-chadha reviewed Aug 11, 2020

View reviewed changes

cypherean approved these changes Aug 11, 2020

View reviewed changes

Update package-lock.json

08d9ba7

sagarpreet-chadha reviewed Aug 11, 2020

View reviewed changes

jywarren changed the title ~~Bump Version from 2.1.1 to 2.1.2, switch to woofmark plots2 branch~~ Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch Aug 11, 2020

jywarren mentioned this pull request Aug 11, 2020

built dist and bumped to v2.1.2 #590

Merged

Merge branch 'main' into bumpVersion2.1.1

8f03774

NitinBhasneria added 2 commits August 12, 2020 07:53

Update package-lock.json

eb716e8

v2.1.3

49d0534

Merge branch 'main' into bumpVersion2.1.1

bb4b70c

Merge branch 'main' into bumpVersion2.1.1

3a27788

jywarren merged commit 06e212d into publiclab:main Aug 14, 2020

jywarren added a commit that referenced this pull request Aug 14, 2020

update to v2.2.0 following #557

2164933

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch #557

Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch #557

NitinBhasneria commented Jul 11, 2020 •

edited by jywarren

Loading

jywarren commented Jul 11, 2020

NitinBhasneria commented Jul 11, 2020

jywarren commented Jul 14, 2020

gitpod-io bot commented Jul 14, 2020 •

edited

Loading

keshav234156 commented Jul 14, 2020

jywarren commented Jul 14, 2020

jywarren commented Jul 14, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 28, 2020

keshav234156 commented Jul 28, 2020

jywarren commented Aug 11, 2020

jywarren Aug 11, 2020 •

edited

Loading

NitinBhasneria Aug 11, 2020

sagarpreet-chadha commented Aug 11, 2020

sagarpreet-chadha left a comment

NitinBhasneria commented Aug 11, 2020

cypherean commented Aug 11, 2020

sagarpreet-chadha Aug 11, 2020

sagarpreet-chadha Aug 11, 2020

jywarren commented Aug 11, 2020

jywarren commented Aug 11, 2020

jywarren commented Aug 11, 2020

Shulammite-Aso commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 13, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch #557

Bump Version from 2.1.2 to 2.1.3, switch to woofmark plots2 branch #557

Conversation

NitinBhasneria commented Jul 11, 2020 • edited by jywarren Loading

Fixes

jywarren commented Jul 11, 2020

NitinBhasneria commented Jul 11, 2020

jywarren commented Jul 14, 2020

gitpod-io bot commented Jul 14, 2020 • edited Loading

keshav234156 commented Jul 14, 2020

jywarren commented Jul 14, 2020

jywarren commented Jul 14, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 28, 2020

keshav234156 commented Jul 28, 2020

jywarren commented Aug 11, 2020

jywarren Aug 11, 2020 • edited Loading

Choose a reason for hiding this comment

NitinBhasneria Aug 11, 2020

Choose a reason for hiding this comment

sagarpreet-chadha commented Aug 11, 2020

sagarpreet-chadha left a comment

Choose a reason for hiding this comment

NitinBhasneria commented Aug 11, 2020

cypherean commented Aug 11, 2020

sagarpreet-chadha Aug 11, 2020

Choose a reason for hiding this comment

sagarpreet-chadha Aug 11, 2020

Choose a reason for hiding this comment

jywarren commented Aug 11, 2020

jywarren commented Aug 11, 2020

jywarren commented Aug 11, 2020

Shulammite-Aso commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 12, 2020

jywarren commented Aug 13, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

jywarren commented Aug 14, 2020

NitinBhasneria commented Jul 11, 2020 •

edited by jywarren

Loading

gitpod-io bot commented Jul 14, 2020 •

edited

Loading

jywarren Aug 11, 2020 •

edited

Loading