-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading Test #545
base: main
Are you sure you want to change the base?
Heading Test #545
Conversation
92c1768
to
34620ad
Compare
@Shreyaa-s Both the above PR's are merged so you can change the description and tell the status whether it is in WIP or it's done. |
Can only be merged after #557 , I'll update the description. |
That's been merged, so I've reset this, hopefully it works, but it may need a rebase. Thanks! Also, a tip is that you can create a PR that builds on another PR branch. Sometimes this can help with such ordering! |
Or, you can include the other PR's commits in this one, and once the other is merged, and this updated, the extra commits would just disappear. Fun tricks! 🎉 |
@shreyaa-sharmaa any updates? |
@sagarpreet-chadha The test is correct. But the change for which I wrote this was introduced in Woofmark. Since we've reverted the latest update of woofmark, the tests won't pass right now. |
To be merged after #557 . Tests adding a heading and switching b/w different heading sizes.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasmine
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!