Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#49): sidebar menu #50

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Fix(#49): sidebar menu #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6110de1
fix(#49): fix names of side menu entries
mari1912 Jul 3, 2024
397c346
fix(#49): show kernel ci logo on side menu
mari1912 Jul 3, 2024
61f4218
fix(#49): add kernel CI title and logo index.html
mari1912 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboard/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link rel="icon" type="image/svg+xml" href="/kernelci.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
<title>Kernel CI</title>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Intl text instead of pure text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is really necessary. This is the title of website, that will appear in the browser tab. It will not change in any language. Other than that, we will need to define it dynamically if we thing is really necessary and it seems to me that is too much working for little gain

</head>
<body>
<div id="root"></div>
Expand Down
Binary file added dashboard/public/kernelci.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion dashboard/public/vite.svg
View file
Open in desktop

This file was deleted.

10 changes: 2 additions & 8 deletions dashboard/src/components/SideMenu/SideMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MdOutlineMonitorHeart, MdOutlineDashboard } from "react-icons/md";
import { MdOutlineMonitorHeart } from "react-icons/md";

import { ImTree, ImImages } from "react-icons/im";

Expand All @@ -23,12 +23,6 @@ type MenuItems = {
const emptyFunc = () : void => {}

const items: MenuItems[] = [
{
onClick: emptyFunc,
idIntl: "routes.dashboard",
icon: <MdOutlineDashboard className="size-5" />,
selected: false,
},
{
onClick: emptyFunc,
idIntl: "routes.treeMonitor",
Expand Down Expand Up @@ -71,7 +65,7 @@ const SideMenu = (): JSX.Element => {
orientation="vertical"
>
<div className="w-full px-4">
<img src="./src/assets/kernelCI_logo.png"className="size-14 text-onSecondary" />
<img src="kernelCI_logo.png"className="size-14 text-onSecondary" />
</div>

<Separator className="my-4 bg-onSecondary-10" />
Expand Down
7 changes: 3 additions & 4 deletions dashboard/src/locales/messages/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ export const messages = {
filters: "Filters",
},
routes: {
dashboard: "Dashboard",
deviceMonitor: "Device Monitor",
labsMonitor: "Labs Monitor",
treeMonitor: "Tree Monitor",
deviceMonitor: "Device",
labsMonitor: "Labs",
treeMonitor: "Tree",
},
table: {
itemsPerPage: "Items per page:",
Expand Down
Loading