Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#49): sidebar menu #50

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Fix(#49): sidebar menu #50

merged 3 commits into from
Jul 4, 2024

Conversation

mari1912
Copy link
Collaborator

@mari1912 mari1912 commented Jul 3, 2024

Description

  • Change the names of entries to "Tree", "Device", "Monitor"
  • Remove the "Dashboard" option
  • Show the kernel ci logo correctly
  • Change the title and image in index.html to "Kernel CI" and kernel ci logo

Related Issues

Visual reference

image

@mari1912 mari1912 self-assigned this Jul 3, 2024
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
<title>Kernel CI</title>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Intl text instead of pure text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is really necessary. This is the title of website, that will appear in the browser tab. It will not change in any language. Other than that, we will need to define it dynamically if we thing is really necessary and it seems to me that is too much working for little gain

@mari1912 mari1912 force-pushed the fix/sidebar-menu branch from c7f9ca2 to 61f4218 Compare July 4, 2024 12:54
@mari1912 mari1912 merged commit 2ea5f3b into main Jul 4, 2024
4 checks passed
@mari1912 mari1912 deleted the fix/sidebar-menu branch July 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Side menu entries
3 participants