Added phy_save() and phy_load() to save and load PHY.

Signed-off-by: Pol Henarejos <[email protected]>
polhenarejos · Jan 29, 2025 · a381e94 · a381e94
1 parent e78ec82
commit a381e94
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 17 deletions.
diff --git a/pico-keys-sdk b/pico-keys-sdk
diff --git a/src/fido/cbor_config.c b/src/fido/cbor_config.c
@@ -246,14 +246,9 @@ int cbor_config(const uint8_t *data, size_t len) {
         else {
             CBOR_ERROR(CTAP2_ERR_UNSUPPORTED_OPTION);
         }
-        uint8_t tmp[PHY_MAX_SIZE];
-        uint16_t tmp_len = 0;
-        memset(tmp, 0, sizeof(tmp));
-        if (phy_serialize_data(&phy_data, tmp, &tmp_len) != PICOKEY_OK) {
+        if (phy_save() != PICOKEY_OK) {
             CBOR_ERROR(CTAP2_ERR_PROCESSING);
         }
-        file_put_data(ef_phy, tmp, tmp_len);
-        low_flash_available();
     }
 #endif
     else {

diff --git a/src/fido/cbor_make_credential.c b/src/fido/cbor_make_credential.c
@@ -455,21 +455,13 @@ int cbor_make_credential(const uint8_t *data, size_t len) {
             if (memcmp(p, "CommissionProfile", 17) == 0) {
                 ret = phy_unserialize_data(user.id.data, user.id.len, &phy_data);
                 if (ret == PICOKEY_OK) {
-                    uint8_t tmp[PHY_MAX_SIZE];
-                    uint16_t tmp_len = 0;
-                    memset(tmp, 0, sizeof(tmp));
-                    if (phy_serialize_data(&phy_data, tmp, &tmp_len) != PICOKEY_OK) {
-                        CBOR_ERROR(CTAP2_ERR_PROCESSING);
-                    }
-                    DEBUG_DATA(tmp,tmp_len);
-                    file_put_data(ef_phy, tmp, tmp_len);
+                    ret = phy_save();
                 }
             }
 #endif
-            if (ret != 0) {
+            if (ret != PICOKEY_OK) {
                 CBOR_ERROR(CTAP2_ERR_PROCESSING);
             }
-            low_flash_available();
        }
     }