Do not init PHY on modifying a single value.

Signed-off-by: Pol Henarejos <[email protected]>
polhenarejos · Jan 29, 2025 · e78ec82 · e78ec82
1 parent 584d2f3
commit e78ec82
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/pico-keys-sdk b/pico-keys-sdk
diff --git a/src/fido/cbor_make_credential.c b/src/fido/cbor_make_credential.c
@@ -455,7 +455,14 @@ int cbor_make_credential(const uint8_t *data, size_t len) {
             if (memcmp(p, "CommissionProfile", 17) == 0) {
                 ret = phy_unserialize_data(user.id.data, user.id.len, &phy_data);
                 if (ret == PICOKEY_OK) {
-                    file_put_data(ef_phy, user.id.data, user.id.len);
+                    uint8_t tmp[PHY_MAX_SIZE];
+                    uint16_t tmp_len = 0;
+                    memset(tmp, 0, sizeof(tmp));
+                    if (phy_serialize_data(&phy_data, tmp, &tmp_len) != PICOKEY_OK) {
+                        CBOR_ERROR(CTAP2_ERR_PROCESSING);
+                    }
+                    DEBUG_DATA(tmp,tmp_len);
+                    file_put_data(ef_phy, tmp, tmp_len);
                 }
             }
 #endif