Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3) support supabase s3 #17163

Closed
wants to merge 3 commits into from
Closed

fix(s3) support supabase s3 #17163

wants to merge 3 commits into from

Conversation

cirospaciari
Copy link
Member

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@robobun
Copy link

robobun commented Feb 8, 2025

Updated 1:14 PM PT - Feb 12th, 2025

@cirospaciari, your commit 433cce0 has 4 failures in Build #11507:


🧪   try this PR locally:

bunx bun-pr 17163

@jakeg
Copy link
Contributor

jakeg commented Feb 10, 2025

I presume this fixes the bug that at the moment instead of:

S3_ENDPOINT="https://xxx.supabase.co/storage/v1/s3/"
S3_BUCKET="first-bucket"

You need to do:

S3_ENDPOINT="https://xxx.supabase.co/"
S3_BUCKET="storage/v1/s3/first-bucket"

... right? Other than that, S3 on Supabase seems to be working great for me.

@cirospaciari
Copy link
Member Author

I presume this fixes the bug that at the moment instead of:

S3_ENDPOINT="https://xxx.supabase.co/storage/v1/s3/"
S3_BUCKET="first-bucket"

You need to do:

S3_ENDPOINT="https://xxx.supabase.co/"
S3_BUCKET="storage/v1/s3/first-bucket"

... right? Other than that, S3 on Supabase seems to be working great for me.

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants