Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3) Support Virtual Hosted-Style endpoints #17292

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 12, 2025

What does this PR do?

Supersedes #17163

Fix: #16272

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@robobun
Copy link

robobun commented Feb 12, 2025

Updated 7:29 PM PT - Feb 13th, 2025

@cirospaciari, your commit 02225a3 has 3 failures in Build #11593:


🧪   try this PR locally:

bunx bun-pr 17292

src/url.zig Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit 79afefa into main Feb 14, 2025
59 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/s3-virtual-host branch February 14, 2025 03:47
@jakeg
Copy link
Contributor

jakeg commented Feb 14, 2025

Can confirm this fixes the issue with Supabase S3 buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Virtual-hosted–style requests for S3
4 participants