-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3) Support Virtual Hosted-Style endpoints #17292
Merged
Merged
+411
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
force-pushed
the
ciro/s3-virtual-host
branch
from
February 13, 2025 02:39
1514607
to
d4b9ad6
Compare
cirospaciari
force-pushed
the
ciro/s3-virtual-host
branch
from
February 13, 2025 04:58
d4b9ad6
to
db3d6c4
Compare
Co-authored-by: Jarred Sumner <[email protected]>
cirospaciari
force-pushed
the
ciro/s3-virtual-host
branch
from
February 14, 2025 00:22
db3d6c4
to
3853fd9
Compare
Can confirm this fixes the issue with Supabase S3 buckets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supersedes #17163
Fix: #16272
How did you verify your code works?
Tests