Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3) fix slice with offset 0 #16400

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(s3) fix slice with offset 0 #16400

merged 1 commit into from
Jan 15, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Jan 14, 2025

What does this PR do?

Fix: #16398

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link

robobun commented Jan 14, 2025

Updated 2:16 PM PT - Jan 14th, 2025

@cirospaciari, your commit 8bb30d5 has passed in #9583! 🎉


🧪   try this PR locally:

bunx bun-pr 16400

@cirospaciari cirospaciari requested review from a team and Jarred-Sumner and removed request for a team January 14, 2025 21:30
@Jarred-Sumner Jarred-Sumner added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@Jarred-Sumner Jarred-Sumner merged commit 8c04818 into main Jan 15, 2025
69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-s3-slie branch January 15, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3file.slice methods always return entire object
3 participants