fix slice with offset 0

oven-sh · Jan 14, 2025 · a6b53d7 · a6b53d7
1 parent e5ea345
commit a6b53d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/s3/client.zig b/src/s3/client.zig
@@ -64,8 +64,6 @@ pub fn downloadSlice(
 ) void {
     const range = brk: {
         if (size) |size_| {
-            if (offset == 0) break :brk null;
-
             var end = (offset + size_);
             if (size_ > 0) {
                 end -= 1;

diff --git a/test/js/bun/s3/s3.test.ts b/test/js/bun/s3/s3.test.ts
@@ -235,6 +235,11 @@ for (let credentials of allCredentials) {
               const text = await file.slice(6, 10).text();
               expect(text).toBe("Bun!");
             });
+            it("should download range with 0 offset", async () => {
+              const file = bucket.file(tmp_filename, options);
+              const text = await file.slice(0, 5).text();
+              expect(text).toBe("Hello");
+            });
 
             it("should check if a key exists or content-length", async () => {
               const file = bucket.file(tmp_filename, options);