Fix the default min_control value for the Thelen2003Muscle
#3997
Conversation
|
@nickbianco can you take a look? |
alexbeattie42
force-pushed
the
marker-set-thelen2003muscle
branch
from
820edfb to
c257ddf
Compare
There was a problem hiding this comment.
I left one comment about the changelog entry and have another general comment: do all of these models need to be updated? In other words, do any of the models set minimum_activation to 0.01 (which would mean a default of 0.01 is valid)?
Also, I suspect many of the tests completely ignore the muscle in the model. Having components under the <defaults> tab is an outdated convention from previous OpenSim versions.
| @@ -57,6 +57,7 @@ v4.6 | |||
| - `OpenSim::ContactHalfSpace`, `OpenSim::ContactMesh`, and `OpenSim::ContactSphere` now check their associated `Appearance`'s `is_visible` flag when deciding whether to emit their associated decorations (#3993). | |||
| - The message associated with `OpenSim::PropertyException` now includes the full absolute path to the component that threw the exception (#3987). | |||
| - Add an improved uniform sampling check for `std::vector` containers to `CommonUtilities` and use the implemented method in the `TableUtilities::filterLowpass` method (#3968, #3978). | |||
| - Fix the default min_control value for the Thelen2003Muscle. Replace all instances of `<min_control> 0.00000000 </min_control>` with `<min_control> 0.01000000 </min_control>` in the default block (#3986). | |||
There was a problem hiding this comment.
The first sentence is a bit misleading. You didn't actually change the default min_control value for Thelen2003Muscle; it is inherited from ScalarActuator. Also, if you were only updating test entries, this might not be worth adding to the changelog, but since there are example files updated, I suppose it is fine.
Fixes issue #3986
CHANGELOG.md (choose one)
This change is