Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for other conda variants by using conda-meta to detect conda #3250

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Jul 10, 2022

Fixes issue #2869

Brief summary of changes

On windows detecting conda to set dll_path relied on presence of conda folder in path, doesn't seem to always hold but conda-meta folder works per testers.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because internal

This change is Reviewable

Copy link
Member

@tkuchida tkuchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@aymanhab
Copy link
Member Author

Thanks @tkuchida 👍

@aymanhab aymanhab merged commit 1161e39 into master Jul 11, 2022
@aymanhab aymanhab deleted the detect_conda_robust branch July 11, 2022 16:03
aymanhab added a commit that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants