Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune CMake options for python per build instructions feedback on github #3208

Merged
merged 2 commits into from
May 23, 2022

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented May 23, 2022

Fixes issue #0

Brief summary of changes

Add CMake variable needed to build python bindings per #2869 (comment)
And mark CMake/Conda options advanced per @carmichaelong

Testing I've completed

ci build

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

@aymanhab aymanhab requested a review from carmichaelong May 23, 2022 16:43
CMakeLists.txt Outdated
@@ -549,6 +550,7 @@ endif()

if(${BUILD_PYTHON_WRAPPING})
set(required_python_version 3)
set(Python3_ROOT_DIR "" CACHE PATH "Top level directory containing Python3 ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could help users with a slightly more descriptive docstring. Perhaps something like "Top level directory containing Python3. For conda environments, this can also be set to the top level directory for a specific environment."

@carmichaelong
Copy link
Member

Thanks @aymanhab. One small comment on the docstring for the new Python variable. Let me know if you the longer message makes sense to you and would be helpful for users, otherwise feel free to tweak it more.

Expand cmake comment per feedback on PR
@aymanhab aymanhab requested a review from carmichaelong May 23, 2022 18:32
Copy link
Member Author

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @carmichaelong)


CMakeLists.txt line 553 at r1 (raw file):

Previously, carmichaelong wrote…

I'm wondering if we could help users with a slightly more descriptive docstring. Perhaps something like "Top level directory containing Python3. For conda environments, this can also be set to the top level directory for a specific environment."

Done.

@carmichaelong
Copy link
Member

LGTM pending CI

@aymanhab
Copy link
Member Author

Thanks @carmichaelong

@aymanhab aymanhab merged commit 29fd6bb into master May 23, 2022
@aymanhab aymanhab deleted the cmake_python_fixes branch May 23, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants