-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Fix file path for concepts/instrumentation/zero-code/index.md #5882
[pt] Fix file path for concepts/instrumentation/zero-code/index.md #5882
Conversation
Does this change affect the link in this page? https://opentelemetry.io/docs/getting-started/ops/ |
Hi @ymotongpoo. I don't see any issue for this page, as the URLs remains the same. |
Thank you, @vitorvasc ! Then it looks great to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vitorvasc : thanks for the PR. Here are a few comments about how we handle changes in locale-specific docs:
- We don't encourage changes that span locales. Please resubmit this for
pt
only and either submit a separate entry forja
pages or letja
approvers handle the update. - Any change to any non-
en
page much update thedefault_lang_commit
commit hash, while ensuring that all changes introduced up until that new commit hash have been incorporated into this PR.
For all the details about handling non-English page drift, see Keeping track of localized-page drift.
@chalin thanks for the heads up. Just updated the PR by replicating the changes on the Also, removed the By the way, should we translate the content for the .svg file? cc @maryliag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
b22ad02
to
80581ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once all checks pass.
![Sem código](./zero-code.svg) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'm glad that you caught this required update (the addition of the image).
@ymotongpoo - please ensure that you make the corresponding changes to the |
I think that would be ideal! |
As mentioned on #5871, this PR updates the Zero-Code Instrumentation page and fixes an issue originally noticed by @EzzioMoreira.
The changes are:
content/pt/docs/concepts/instrumentation/zero-code.md
->content/pt/docs/concepts/instrumentation/zero-code/index.md
en
version shows.