Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Fix file path for concepts/instrumentation/zero-code/index.md #5882

Merged

Conversation

vitorvasc
Copy link
Contributor

@vitorvasc vitorvasc commented Jan 6, 2025

As mentioned on #5871, this PR updates the Zero-Code Instrumentation page and fixes an issue originally noticed by @EzzioMoreira.

The changes are:

  • File path updated from content/pt/docs/concepts/instrumentation/zero-code.md -> content/pt/docs/concepts/instrumentation/zero-code/index.md
  • Update page content and add the .svg reference as the en version shows.

@vitorvasc vitorvasc requested a review from a team as a code owner January 6, 2025 12:23
@opentelemetrybot opentelemetrybot requested a review from a team January 6, 2025 12:23
@opentelemetrybot opentelemetrybot requested review from a team January 6, 2025 12:23
@vitorvasc vitorvasc changed the title [pt][ja Fix file path for concepts/instrumentation/zero-code/index.md [pt][ja] Fix file path for concepts/instrumentation/zero-code/index.md Jan 6, 2025
@ymotongpoo
Copy link
Contributor

Does this change affect the link in this page? https://opentelemetry.io/docs/getting-started/ops/

@vitorvasc
Copy link
Contributor Author

@ymotongpoo
Copy link
Contributor

Thank you, @vitorvasc ! Then it looks great to me!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vitorvasc : thanks for the PR. Here are a few comments about how we handle changes in locale-specific docs:

  1. We don't encourage changes that span locales. Please resubmit this for pt only and either submit a separate entry for ja pages or let ja approvers handle the update.
  2. Any change to any non-en page much update the default_lang_commit commit hash, while ensuring that all changes introduced up until that new commit hash have been incorporated into this PR.

For all the details about handling non-English page drift, see Keeping track of localized-page drift.

@chalin chalin requested a review from a team January 6, 2025 17:06
@opentelemetrybot opentelemetrybot requested review from a team January 6, 2025 21:55
@vitorvasc vitorvasc changed the title [pt][ja] Fix file path for concepts/instrumentation/zero-code/index.md [pt] Fix file path for concepts/instrumentation/zero-code/index.md Jan 6, 2025
@vitorvasc
Copy link
Contributor Author

@chalin thanks for the heads up. Just updated the PR by replicating the changes on the en version -- actually, didn't notice that it was actually a change beyond the file being renamed.

Also, removed the ja translation from this pull request, so, this should cover only the pt version.

By the way, should we translate the content for the .svg file? cc @maryliag

Copy link
Contributor

@EzzioMoreira EzzioMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@chalin chalin force-pushed the fix-path-zero-code-instrumentation branch from b22ad02 to 80581ee Compare January 7, 2025 15:06
@opentelemetrybot opentelemetrybot requested a review from a team January 7, 2025 15:07
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all checks pass.

Comment on lines +16 to +17
![Sem código](./zero-code.svg)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'm glad that you caught this required update (the addition of the image).

@chalin
Copy link
Contributor

chalin commented Jan 7, 2025

@ymotongpoo - please ensure that you make the corresponding changes to the jp pages when your team has the time.

@chalin chalin merged commit f765d42 into open-telemetry:main Jan 7, 2025
17 checks passed
@maryliag
Copy link
Contributor

maryliag commented Jan 7, 2025

By the way, should we translate the content for the .svg file?

I think that would be ideal!

chalin pushed a commit to chalin/opentelemetry.io that referenced this pull request Jan 7, 2025
chalin pushed a commit to chalin/opentelemetry.io that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants