Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert internal-class-loader tests from groovy to java #12983

Merged
merged 6 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.javaagent.instrumentation.internal.classloader;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;

import org.junit.jupiter.api.Test;

class RegressionTest {
// https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/5155
// loading a class that is extended/implemented by a helper class causes
// java.lang.LinkageError: loader 'app' (instance of
// jdk.internal.loader.ClassLoaders$AppClassLoader)
// attempted duplicate interface definition for org.apache.commons.lang3.function.FailableCallable
// this test verifies that the duplicate class definition LinkageError is not thrown into
// application code
@Test
void noDuplicateClassDefinition() throws ClassNotFoundException {
assertThat(Class.forName("org.apache.commons.lang3.function.FailableCallable")).isNotNull();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.javaagent.instrumentation.internal.classloader;

import static io.opentelemetry.instrumentation.test.utils.GcUtils.awaitGc;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.lang.ref.WeakReference;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.charset.Charset;
import java.time.Duration;
import java.util.Collections;
import java.util.Enumeration;
import java.util.List;
import java.util.concurrent.atomic.AtomicReference;
import org.apache.commons.lang3.SystemUtils;
import org.junit.jupiter.api.Test;

class ResourceInjectionTest {

private static String trimStream(URL url) throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to call this method readLine

try (BufferedReader reader =
new BufferedReader(new InputStreamReader(url.openStream(), Charset.defaultCharset()))) {
return reader.readLine().trim();
}
}

@Test
@SuppressWarnings("UnnecessaryAsync")
void resourcesInjectedToNonDelegatingClassLoader() throws Exception {

String resourceName = "test-resources/test-resource.txt";
URL[] urls = {SystemUtils.class.getProtectionDomain().getCodeSource().getLocation()};
AtomicReference<URLClassLoader> emptyLoader =
new AtomicReference<>(new URLClassLoader(urls, null));

Enumeration<URL> resourceUrls = emptyLoader.get().getResources(resourceName);
assertThat(resourceUrls.hasMoreElements()).isFalse();
resourceUrls = null;

URLClassLoader notInjectedLoader = new URLClassLoader(urls, null);

// this triggers resource injection
emptyLoader.get().loadClass(SystemUtils.class.getName());

List<URL> resourceList = Collections.list(emptyLoader.get().getResources(resourceName));

assertThat(resourceList.size()).isEqualTo(2);
assertThat(trimStream(resourceList.get(0))).isEqualTo("Hello world!");
assertThat(trimStream(resourceList.get(1))).isEqualTo("Hello there");

assertThat(notInjectedLoader.getResources(resourceName).hasMoreElements()).isFalse();

// references to emptyloader are gone
emptyLoader.get().close(); // cleanup
WeakReference<URLClassLoader> ref = new WeakReference<>(emptyLoader.get());
emptyLoader.set(null);

awaitGc(ref, Duration.ofSeconds(10));

assertThat(ref.get()).isNull();
}
}
Loading