Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert internal-class-loader tests from groovy to java #12983

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Convert internal-class-loader tests from groovy to java #12983

merged 6 commits into from
Jan 3, 2025

Conversation

jaydeluca
Copy link
Member

Related to #7195

@jaydeluca jaydeluca mentioned this pull request Dec 31, 2024
Open
@jaydeluca jaydeluca marked this pull request as ready for review December 31, 2024 14:13
@jaydeluca jaydeluca requested a review from a team as a code owner December 31, 2024 14:13
laurit
laurit reviewed Jan 2, 2025
View reviewed changes
...a/io/opentelemetry/javaagent/instrumentation/internal/classloader/ResourceInjectionTest.java Outdated

class ResourceInjectionTest {

private static String trimStream(URL url) throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to call this method readLine

@laurit laurit merged commit c16de48 into open-telemetry:main Jan 3, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaydeluca @laurit @steverao