Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[githubgen] PR feedback follow-ups #655

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 7, 2025

Follow up to #639

mowies added 2 commits January 7, 2025 13:35
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 53.92157% with 47 lines in your changes missing coverage. Please review.

Project coverage is 50.33%. Comparing base (fcfa1a6) to head (f714d4d).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
githubgen/codeowners.go 65.07% 21 Missing and 1 partial ⚠️
githubgen/main.go 14.28% 18 Missing ⚠️
githubgen/issuetemplates.go 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   47.13%   50.33%   +3.20%     
==========================================
  Files          56       57       +1     
  Lines        3214     3401     +187     
==========================================
+ Hits         1515     1712     +197     
+ Misses       1548     1527      -21     
- Partials      151      162      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mowies added 4 commits January 7, 2025 14:14
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@MrAlias MrAlias mentioned this pull request Jan 7, 2025
mowies added 5 commits January 7, 2025 16:54
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies added 6 commits January 8, 2025 12:40
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant