Exclude githubgen from released modules #657
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 57 57
Lines 3381 3381
=======================================
Hits 1652 1652
Misses 1568 1568
Partials 161 161 ☔ View full report in Codecov by Sentry. |
jade-guiton-dd
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM. I guess this means @mowies will have to add it back once the follow-up PRs are done and the module is ready to be released.
|
yup, no problem |
mowies
approved these changes
Jan 8, 2025
mx-psi
approved these changes
Jan 8, 2025
MrAlias
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excludes githubgen from the released modules, so 0.16.0 can be cut (#656) before the additional work on that module is finished (#655).