Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-8027- PayPal not working (backport #24609) #24639

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Bugfix FXIOS-8027- PayPal not working (backport #24609) #24639

merged 1 commit into from
Feb 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Continue the work done in #24497

  • I've added unit test for Paypal user agent to cover the changes done in the previous PR
  • Block createWebViewWith if it is Paypal popup because the logic we have creates a new blank page tab because WKNavigationAction request is empty.
  • Reorganize functions

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #24609 done by [Mergify](https://mergify.com).

@yoanarios @mergify
Bugfix FXIOS-8027- PayPal not working (#24609)
5afc783 
Co-authored-by: lmarceau <[email protected]>
(cherry picked from commit 00d9b09)
@mergify mergify bot requested a review from a team as a code owner February 7, 2025 15:40
@mergify mergify bot requested review from dataports and removed request for a team February 7, 2025 15:40
@mergify mergify bot mentioned this pull request Feb 7, 2025
Merged
6 tasks
@yoanarios yoanarios removed the request for review from dataports February 7, 2025 15:41
@yoanarios yoanarios merged commit 8eae5bf into release/v136 Feb 7, 2025
12 checks passed
@yoanarios yoanarios deleted the mergify/bp/release/v136/pr-24609 branch February 7, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoanarios yoanarios yoanarios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoanarios