Bugfix FXIOS-8027- PayPal not working #24609
Merged
+36
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-02-06.at.11.54.14.mp4Paypal popUp is now shown same as on iPhone as a Popup in the tab where the button was pressed |
lmarceau
approved these changes
Feb 6, 2025
...ontend/Browser/BrowserViewController/Extensions/BrowserViewController+WebViewDelegates.swift
Outdated
Show resolved
Hide resolved
cyndichin
reviewed
Feb 6, 2025
...ontend/Browser/BrowserViewController/Extensions/BrowserViewController+WebViewDelegates.swift
Show resolved
Hide resolved
…nsions/BrowserViewController+WebViewDelegates.swift Co-authored-by: lmarceau <[email protected]>
| type: WKMediaCaptureType, | ||
| decisionHandler: @escaping (WKPermissionDecision) -> Void) { | ||
| // If the tab isn't the selected one or we're on the homepage, do not show the media capture prompt | ||
| guard tabManager.selectedTab?.webView == webView, !contentContainer.hasLegacyHomepage else { |
There was a problem hiding this comment.
Minor nitpick: this should probably be an identity check (===). Offhand I think == will just fall into the default isEqualTo: for WKWebView which presumably just compares pointers anyway, but it would make sense to be explicit.
6 tasks
|
@Mergifyio backport release/v136 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Co-authored-by: lmarceau <[email protected]> (cherry picked from commit 00d9b09)
6 tasks
yoanarios
added a commit
that referenced
this pull request
Feb 7, 2025
Bugfix FXIOS-8027- PayPal not working (#24609) Co-authored-by: lmarceau <[email protected]> (cherry picked from commit 00d9b09) Co-authored-by: yoanarios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Continue the work done in #24497
createWebViewWithif it is Paypal popup because the logic we have creates a new blank page tab because WKNavigationAction request is empty.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)