Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from bedrock #454

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Updates from bedrock #454

merged 3 commits into from
Dec 2, 2024

Conversation

MozmarRobot
Copy link
Collaborator

From file changes in mozilla/bedrock@395be1b

@MozmarRobot MozmarRobot requested a review from a team as a code owner November 27, 2024 06:09
@flodolo flodolo force-pushed the update-from-bedrock-395be1b7 branch from c6c6328 to 20a27b2 Compare November 27, 2024 08:09
@flodolo
Copy link
Contributor

flodolo commented Nov 27, 2024

@stephaniehobson @craigcook
Is the goal to have this localized? Currently, it will only be localized by Smartling languages (paid agency, which covers French and German but not much more).

Otherwise, it needs to be added here https://github.com/mozilla/bedrock/blob/main/l10n/configs/pontoon.toml#L253-L301

m24-about-read-more = Read more
m24-about-read-the-latest = Read the latest { -brand-name-mozilla } news & articles
m24-about-14-ai-projects = 14 AI projects to watch: { -brand-name-mozilla }’s first Builders Accelerator cohort kicks off
m24-about-at-our-rise25 = At our Rise25 Awards, the future of AI is trustworthy, inclusive and accountable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add Rise25 to the brands.ftl file per our discussion yesterday.

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our previous discussions, this page is open to the communities too, so let's add an entry in the pontoon.toml file, and add Rise25 to the brands.ftl file.

@stephaniehobson
Copy link
Contributor

@peiying2 Ah sorry 🤦‍♀️ I did it for the homepage but not the about page.

@stephaniehobson
Copy link
Contributor

@flodolo yes, any community can translate it.

Is this the right thing to add?

[[paths]]
    reference = "en/mozorg/home-24.ftl"
    l10n = "{locale}/mozorg/home-24.ftl"

@peiying2
Copy link
Contributor

@flodolo yes, any community can translate it.

Is this the right thing to add?

[[paths]]
    reference = "en/mozorg/home-24.ftl"
    l10n = "{locale}/mozorg/home-24.ftl"

You can follow the format and add the new page in alphabetic order:

[[paths]]

@flodolo
Copy link
Contributor

flodolo commented Nov 27, 2024

@flodolo yes, any community can translate it.

Is this the right thing to add?

[[paths]]
    reference = "en/mozorg/home-24.ftl"
    l10n = "{locale}/mozorg/home-24.ftl"

The file here is en/mozorg/about-m24.ftl, not home-24.ftl. Other than that, yes

@stephaniehobson
Copy link
Contributor

PR with fixes.

navigation-refresh-mozilla-ventures = { -brand-name-mozilla } Ventures
navigation-refresh-mozilla-ventures-v2 = { -brand-name-mozilla-venture }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be plural { -brand-name-mozilla-ventures }

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mozilla Ventures is plural. Also are you going to commit the other new file?

@peiying2 peiying2 merged commit fccb746 into master Dec 2, 2024
2 checks passed
@peiying2 peiying2 deleted the update-from-bedrock-395be1b7 branch December 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants