Updates from bedrock #431
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # This Source Code Form is subject to the terms of the Mozilla Public | ||
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| navigation-refresh-mozilla = { -brand-name-mozilla } | ||
|
|
||
| ## About us | ||
|
|
||
| navigation-refresh-about-us = About us | ||
| navigation-refresh-close-about-us-menu = Close About us menu | ||
| navigation-refresh-mozilla-manifesto = { -brand-name-mozilla } manifesto | ||
| navigation-refresh-mozilla-foundation = { -brand-name-mozilla-foundation } | ||
| navigation-refresh-get-involved = Get involved | ||
| navigation-refresh-innovation-projects = Innovation Projects | ||
| navigation-refresh-blog = Blog | ||
|
|
||
| ## Firefox | ||
|
|
||
| navigation-refresh-firefox-browsers = { -brand-name-firefox-browsers } | ||
| navigation-refresh-close-firefox-browsers-menu = Close { -brand-name-firefox-browsers } menu | ||
| navigation-refresh-firefox-for-desktop = { -brand-name-firefox } for Desktop | ||
| navigation-refresh-firefox-for-android = { -brand-name-firefox } for { -brand-name-android } | ||
| navigation-refresh-firefox-for-ios = { -brand-name-firefox } for { -brand-name-ios } | ||
| navigation-refresh-firefox-focus = { -brand-name-firefox-focus } | ||
| navigation-refresh-firefox-relay = { -brand-name-firefox-relay } | ||
| navigation-refresh-all-products = All products | ||
| navigation-refresh-firefox-blog = { -brand-name-firefox } Blog | ||
|
There was a problem hiding this comment. Should this be lower case B so it reads |
||
|
|
||
| ## Products | ||
|
|
||
| navigation-refresh-products = Products | ||
| navigation-refresh-close-products-menu = Close Products menu | ||
| navigation-refresh-mozilla-monitor = { -brand-name-monitor } | ||
| navigation-refresh-pocket = { -brand-name-pocket } | ||
| navigation-refresh-mozilla-vpn = { -brand-name-vpn } | ||
| navigation-refresh-mdn-plus = { -brand-name-mdn-plus } | ||
| navigation-refresh-fakespot = { -brand-name-fakespot } | ||
| navigation-refresh-thunderbird = { -brand-name-thunderbird } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
Innovation projects(lower case P) to be consistent with other list of items?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentance case is the official word going foward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People are doing a bit of everything right now. @craigcook do you want take a pass on capitalization on Monday? I can if you're busy but I know you're better with speling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this updated soon as it's time sensitive. Anymore strings to come in the next couple of days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgibson not sure if you can help fix this. We are pressing for time. If this is the last update before next week, let's finalize it. If there are more things to come, can we bundle them? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peiying2 I will take a look here thanks for the ping
Edit: I'm going to assume sentence case is what we should be using for all titles in the nav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peiying2 PR here that should hopefully address things: mozilla/bedrock#15164
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!