-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from bedrock #431
Updates from bedrock #431
Conversation
From file changes in mozilla/bedrock@cf21cf2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craigcook not sure who is working on this PR, but in looking at https://www-dev.allizom.org/en-US/ - the title case or capitalization of title case is inconsistent depending on where you look. In most situation, it looks like this Title case
. But some are not: Firefox Blog
(under Firefox Browsers). Under About us
where Innovation Projects
is not consistent with the rest (MoFo is an exception in this case).
The footer's title case seems to have capital initials like Footer Title Case
vs. Navigation title case
(or inconsistent within each menu).
en/navigation_refresh.ftl
Outdated
navigation-refresh-mozilla-manifesto = { -brand-name-mozilla } manifesto | ||
navigation-refresh-mozilla-foundation = { -brand-name-mozilla-foundation } | ||
navigation-refresh-get-involved = Get involved | ||
navigation-refresh-innovation-projects = Innovation Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Innovation projects
(lower case P) to be consistent with other list of items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentance case is the official word going foward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People are doing a bit of everything right now. @craigcook do you want take a pass on capitalization on Monday? I can if you're busy but I know you're better with speling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this updated soon as it's time sensitive. Anymore strings to come in the next couple of days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgibson not sure if you can help fix this. We are pressing for time. If this is the last update before next week, let's finalize it. If there are more things to come, can we bundle them? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peiying2 I will take a look here thanks for the ping
Edit: I'm going to assume sentence case is what we should be using for all titles in the nav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peiying2 PR here that should hopefully address things: mozilla/bedrock#15164
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call out a few list items to use "sentence case".
Do we change Fireflx Browsers
to Firefox browsers
?
en/navigation_refresh.ftl
Outdated
navigation-refresh-firefox-focus = { -brand-name-firefox-focus } | ||
navigation-refresh-firefox-relay = { -brand-name-firefox-relay } | ||
navigation-refresh-all-products = All products | ||
navigation-refresh-firefox-blog = { -brand-name-firefox } Blog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be lower case B so it reads Firefox blog
?
From file changes in mozilla/bedrock@2702fb9
From file changes in mozilla/bedrock@cf21cf2