Updates from bedrock #381
Merged
Updates from bedrock #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From file changes in mozilla/bedrock@9671d0b
peiying2
requested changes
Mar 11, 2024
There was a problem hiding this comment.
@robhudson just one minor comment on the expression of never-ending drumbeat. It needs a hyphenation. Everything else looks good.
craigcook
added a commit
to craigcook/bedrock
that referenced
this pull request
Mar 12, 2024
From file changes in mozilla/bedrock@48d8f0d
From file changes in mozilla/bedrock@2ea351e
craigcook
added a commit
to mozilla/bedrock
that referenced
this pull request
Mar 13, 2024
From file changes in mozilla/bedrock@05a8d56
peiying2
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From file changes in mozilla/bedrock@9671d0b