Updates from bedrock #379
Merged
Updates from bedrock #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From file changes in mozilla/bedrock@7bb1b15
From file changes in mozilla/bedrock@f264fd7
peiying2
requested changes
Feb 28, 2024
There was a problem hiding this comment.
@craigcook called out a few things, mostly consistencies
- Translation or Translations
- Cloud services or cloud services
- The variables. I think we decided to simplify it so they are not so error prone when localizers work on them.
From file changes in mozilla/bedrock@96ab8a1
From file changes in mozilla/bedrock@bce44fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From file changes in mozilla/bedrock@7bb1b15