-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to use string literal type in ArrayBuffer's Symbol.toStringTag
#60150
Open
petamoriken
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
petamoriken:fix/arraybuffer-tostringtag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−7
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
tests/baselines/reference/assignSharedArrayBufferToArrayBuffer.errors.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
assignSharedArrayBufferToArrayBuffer.ts(1,5): error TS2322: Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. | ||
Types of property '[Symbol.toStringTag]' are incompatible. | ||
Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'. | ||
|
||
|
||
==== assignSharedArrayBufferToArrayBuffer.ts (1 errors) ==== | ||
var foo: ArrayBuffer = new SharedArrayBuffer(1024); // should error | ||
~~~ | ||
!!! error TS2322: Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'. | ||
!!! error TS2322: Types of property '[Symbol.toStringTag]' are incompatible. | ||
!!! error TS2322: Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'. |
7 changes: 7 additions & 0 deletions
7
tests/baselines/reference/assignSharedArrayBufferToArrayBuffer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
//// [tests/cases/conformance/es2017/assignSharedArrayBufferToArrayBuffer.ts] //// | ||
|
||
//// [assignSharedArrayBufferToArrayBuffer.ts] | ||
var foo: ArrayBuffer = new SharedArrayBuffer(1024); // should error | ||
|
||
//// [assignSharedArrayBufferToArrayBuffer.js] | ||
var foo = new SharedArrayBuffer(1024); // should error |
8 changes: 8 additions & 0 deletions
8
tests/baselines/reference/assignSharedArrayBufferToArrayBuffer.symbols
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
//// [tests/cases/conformance/es2017/assignSharedArrayBufferToArrayBuffer.ts] //// | ||
|
||
=== assignSharedArrayBufferToArrayBuffer.ts === | ||
var foo: ArrayBuffer = new SharedArrayBuffer(1024); // should error | ||
>foo : Symbol(foo, Decl(assignSharedArrayBufferToArrayBuffer.ts, 0, 3)) | ||
>ArrayBuffer : Symbol(ArrayBuffer, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --)) | ||
>SharedArrayBuffer : Symbol(SharedArrayBuffer, Decl(lib.es2017.sharedmemory.d.ts, --, --), Decl(lib.es2017.sharedmemory.d.ts, --, --)) | ||
|
13 changes: 13 additions & 0 deletions
13
tests/baselines/reference/assignSharedArrayBufferToArrayBuffer.types
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
//// [tests/cases/conformance/es2017/assignSharedArrayBufferToArrayBuffer.ts] //// | ||
|
||
=== assignSharedArrayBufferToArrayBuffer.ts === | ||
var foo: ArrayBuffer = new SharedArrayBuffer(1024); // should error | ||
>foo : ArrayBuffer | ||
> : ^^^^^^^^^^^ | ||
>new SharedArrayBuffer(1024) : SharedArrayBuffer | ||
> : ^^^^^^^^^^^^^^^^^ | ||
>SharedArrayBuffer : SharedArrayBufferConstructor | ||
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
>1024 : 1024 | ||
> : ^^^^ | ||
|
4 changes: 4 additions & 0 deletions
4
tests/cases/conformance/es2017/assignSharedArrayBufferToArrayBuffer.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// @target: es5 | ||
// @lib: es2015,es2017.sharedmemory | ||
|
||
var foo: ArrayBuffer = new SharedArrayBuffer(1024); // should error |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this type because CI failed, but it might be better to revert it.