Fix to use string literal type in ArrayBuffer's `Symbol.toStringTag` #60150

petamoriken · 2024-10-06T12:10:40Z

jakebailey · 2024-10-08T17:47:40Z

typescript-bot · 2024-10-08T17:47:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-08T18:28:03Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60150/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[NEW] error TS1360: Type 'false' does not satisfy the expected type 'true'.
- packages/effect/test/Match.test.ts#L559 in packages/effect/tsconfig.test.json
- packages/effect/test/Match.test.ts#L563 in packages/effect/tsconfig.test.json
[NEW] error TS2769: No overload matches this call.
- packages/experimental/test/MsgPack.test.ts#L9 in packages/experimental/tsconfig.test.json
- packages/experimental/test/Ndjson.test.ts#L9 in packages/experimental/tsconfig.test.json

puppeteer

test/tsconfig.json

[NEW] error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- test/src/golden-utils.ts#L155 in test/tsconfig.json
[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- test/src/network.spec.ts#L407 in test/tsconfig.json
- test/src/network.spec.ts#L418 in test/tsconfig.json

packages/testserver/tsconfig.json

[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'InputType'.
- packages/testserver/src/index.ts#L309 in packages/testserver/tsconfig.json

packages/puppeteer-core/tsconfig.json

[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.

pyright

/mnt/ts_downloads/_/m/pyright/build.sh

[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/common/realFileSystem.ts(98,32)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/common/realFileSystem.ts(98,32)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/tests/harness/vfs/filesystem.ts(1202,28)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/common/realFileSystem.ts(98,32)
[NEW] error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- /mnt/ts_downloads/_/m/pyright/pyright: ../pyright-internal/src/common/realFileSystem.ts(299,36)
- /mnt/ts_downloads/_/m/pyright/pyright-internal: src/common/realFileSystem.ts(299,36)
- /mnt/ts_downloads/_/m/pyright/vscode-pyright: ../pyright-internal/src/common/realFileSystem.ts(299,36)

webpack

tsconfig.types.json

[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
[NEW] error TS2769: No overload matches this call.
- lib/cache/PackFileCacheStrategy.js#L1030
- lib/serialization/FileMiddleware.js#L318
[NEW] error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
[NEW] error TS2344: Type 'Buffer' does not satisfy the constraint 'ArrayBufferView'.
- lib/util/fs.js#L434

tsconfig.json

[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
[NEW] error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
[NEW] error TS2769: No overload matches this call.
- lib/cache/PackFileCacheStrategy.js#L1030
- lib/serialization/FileMiddleware.js#L318
[NEW] error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
[NEW] error TS2344: Type 'Buffer' does not satisfy the constraint 'ArrayBufferView'.
- lib/util/fs.js#L434

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2430: Interface 'Buffer' incorrectly extends interface 'Uint8Array<ArrayBufferLike>'.
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/@types/node/buffer.d.ts#L596 in src/tsconfig-library-base.json
[NEW] error TS2344: Type 'Buffer' does not satisfy the constraint 'ArrayBufferView'.
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/@types/node/fs/promises.d.ts#L57 in src/tsconfig-library-base.json
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/@types/node/fs/promises.d.ts#L226 in src/tsconfig-library-base.json
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/webpack/types.d.ts#L5544 in src/tsconfig-library-base.json
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/webpack/types.d.ts#L11036 in src/tsconfig-library-base.json

typescript-bot · 2024-10-08T18:30:42Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Changes are too big to display here, please check the log.

You can check the log here.

typescript-bot · 2024-10-08T18:40:14Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,694k (± 0.76%)}	_{195,781k (± 0.72%)}	_~	_192,921k	_196,537k	_{p=0.689 n=6}
_{Parse Time}	_{1.61s (± 1.77%)}	_{1.61s (± 0.68%)}	_~	_1.59s	_1.62s	_{p=0.460 n=6}
_{Bind Time}	_{0.88s (± 1.38%)}	_{0.87s (± 1.03%)}	_~	_0.86s	_0.88s	_{p=0.362 n=6}
_{Check Time}	_{11.72s (± 0.57%)}	_{11.74s (± 0.38%)}	_~	_11.66s	_11.78s	_{p=0.470 n=6}
_{Emit Time}	_{3.43s (± 5.31%)}	_{3.36s (± 3.23%)}	_~	_3.24s	_3.54s	_{p=0.630 n=6}
_{Total Time}	_{17.63s (± 0.91%)}	_{17.57s (± 0.76%)}	_~	_17.39s	_17.79s	_{p=0.630 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₅₂	_{🔻+19 (+57.58%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_947,886	_948,069	_{+183 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,840	_410,781	_{-59 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,780k (± 0.00%)}	_{1,224,987k (± 0.01%)}	_{+208k (+ 0.02%)}	_1,224,908k	_1,225,111k	_{p=0.005 n=6}
_{Parse Time}	_{8.03s (± 1.21%)}	_{8.14s (± 1.15%)}	_{+0.11s (+ 1.41%)}	_7.97s	_8.24s	_{p=0.044 n=6}
_{Bind Time}	_{2.27s (± 1.10%)}	_{2.27s (± 0.77%)}	_~	_2.25s	_2.30s	_{p=1.000 n=6}
_{Check Time}	_{37.94s (± 0.26%)}	_{38.03s (± 0.51%)}	_~	_37.80s	_38.29s	_{p=0.470 n=6}
_{Emit Time}	_{18.22s (± 0.34%)}	_{18.38s (± 0.34%)}	_{+0.16s (+ 0.85%)}	_18.33s	_18.50s	_{p=0.005 n=6}
_{Total Time}	_{66.47s (± 0.30%)}	_{66.82s (± 0.38%)}	_~	_66.52s	_67.19s	_{p=0.078 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,678	_2,529,678	_~	_~	_~	_{p=1.000 n=6}
_Types	_916,161	_916,161	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,165k (± 0.00%)}	_{2,341,212k (± 0.00%)}	_~	_2,341,101k	_2,341,339k	_{p=0.298 n=6}
_{Parse Time}	_{11.27s (± 1.44%)}	_{11.17s (± 0.41%)}	_~	_11.12s	_11.24s	_{p=0.109 n=6}
_{Bind Time}	_{2.61s (± 2.10%)}	_{2.62s (± 1.01%)}	_~	_2.57s	_2.65s	_{p=1.000 n=6}
_{Check Time}	_{90.78s (± 1.17%)}	_{90.51s (± 0.37%)}	_~	_89.98s	_90.87s	_{p=0.936 n=6}
_{Emit Time}	_{0.35s (± 3.04%)}	_{0.35s (± 3.61%)}	_~	_0.33s	_0.36s	_{p=0.456 n=6}
_{Total Time}	_{105.02s (± 0.98%)}	_{104.66s (± 0.34%)}	_~	_104.11s	_105.05s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,107	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,267	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,257k (± 0.02%)}	_{3,146,922k (± 0.04%)}	_~	_3,145,628k	_3,148,186k	_{p=0.471 n=6}
_{Parse Time}	_{8.18s (± 0.61%)}	_{8.24s (± 1.15%)}	_~	_8.12s	_8.36s	_{p=0.297 n=6}
_{Bind Time}	_{2.87s (± 1.11%)}	_{2.75s (± 5.51%)}	_~	_2.52s	_2.88s	_{p=0.109 n=6}
_{Check Time}	_{53.14s (± 0.10%)}	_{53.05s (± 0.33%)}	_~	_52.85s	_53.32s	_{p=0.226 n=6}
_{Emit Time}	_{4.37s (± 2.27%)}	_{4.29s (± 2.15%)}	_~	_4.18s	_4.42s	_{p=0.173 n=6}
_{Total Time}	_{68.57s (± 0.22%)}	_{68.32s (± 0.20%)}	_{-0.25s (- 0.36%)}	_68.09s	_68.45s	_{p=0.031 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,107	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,267	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,005,080k (±11.14%)}	_{2,498,993k (± 0.04%)}	_{🟩-506,086k (-16.84%)}	_2,497,159k	_2,499,861k	_{p=0.045 n=6}
_{Parse Time}	_{8.50s (± 1.95%)}	_{8.18s (± 0.31%)}	_{🟩-0.33s (- 3.82%)}	_8.13s	_8.20s	_{p=0.005 n=6}
_{Bind Time}	_{2.63s (± 2.14%)}	_{2.68s (± 1.66%)}	_~	_2.63s	_2.74s	_{p=0.149 n=6}
_{Check Time}	_{53.39s (± 0.39%)}	_{53.55s (± 0.25%)}	_~	_53.34s	_53.68s	_{p=0.173 n=6}
_{Emit Time}	_{4.34s (± 3.06%)}	_{4.39s (± 3.42%)}	_~	_4.18s	_4.57s	_{p=0.521 n=6}
_{Total Time}	_{68.87s (± 0.48%)}	_{68.81s (± 0.27%)}	_~	_68.62s	_69.10s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,786	_261,786	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,508	_106,508	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,785k (± 0.01%)}	_{438,754k (± 0.02%)}	_~	_438,678k	_438,848k	_{p=0.471 n=6}
_{Parse Time}	_{3.54s (± 1.36%)}	_{3.53s (± 0.91%)}	_~	_3.50s	_3.58s	_{p=0.936 n=6}
_{Bind Time}	_{1.32s (± 0.80%)}	_{1.32s (± 1.04%)}	_~	_1.30s	_1.34s	_{p=1.000 n=6}
_{Check Time}	_{18.91s (± 0.54%)}	_{18.85s (± 0.49%)}	_~	_18.71s	_18.98s	_{p=0.335 n=6}
_{Emit Time}	_{1.54s (± 0.95%)}	_{1.53s (± 1.14%)}	_~	_1.51s	_1.56s	_{p=0.417 n=6}
_{Total Time}	_{25.30s (± 0.37%)}	_{25.23s (± 0.39%)}	_~	_25.06s	_25.35s	_{p=0.261 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₉	_{+1 (+ 1.47%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_225,919	_225,788	_{-131 (- 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,415	_94,293	_{-122 (- 0.13%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,109k (± 0.01%)}	_{370,941k (± 0.01%)}	_{-169k (- 0.05%)}	_370,889k	_371,010k	_{p=0.005 n=6}
_{Parse Time}	_{2.90s (± 0.53%)}	_{2.88s (± 0.98%)}	_~	_2.85s	_2.93s	_{p=0.086 n=6}
_{Bind Time}	_{1.58s (± 1.76%)}	_{1.58s (± 0.74%)}	_~	_1.57s	_1.60s	_{p=0.460 n=6}
_{Check Time}	_{16.36s (± 0.51%)}	_{16.36s (± 0.36%)}	_~	_16.27s	_16.42s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.84s (± 0.30%)}	_{20.83s (± 0.39%)}	_~	_20.70s	_20.93s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₈	_{🔻+5 (+166.67%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,113,231	_3,113,202	_{-29 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,073,156	_1,073,145	_{-11 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,206,566k (± 0.00%)}	_{3,206,667k (± 0.00%)}	_~	_3,206,501k	_3,206,765k	_{p=0.471 n=6}
_{Parse Time}	_{14.18s (± 3.01%)}	_{13.98s (± 0.29%)}	_~	_13.92s	_14.03s	_{p=0.421 n=6}
_{Bind Time}	_{4.50s (± 2.83%)}	_{4.39s (± 0.45%)}	_~	_4.35s	_4.41s	_{p=0.103 n=6}
_{Check Time}	_{84.08s (± 2.42%)}	_{84.74s (± 1.18%)}	_~	_83.81s	_86.69s	_{p=0.230 n=6}
_{Emit Time}	_{24.68s (± 9.16%)}	_{23.70s (± 8.76%)}	_~	_22.24s	_26.60s	_{p=0.093 n=6}
_{Total Time}	_{127.44s (± 2.20%)}	_{126.80s (± 2.25%)}	_~	_124.67s	_131.66s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₂₈	_{🔻+28 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_285,172	_285,552	_{+380 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_115,780	_116,512	_{+732 (+ 0.63%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{434,858k (± 0.01%)}	_{435,970k (± 0.03%)}	_{+1,112k (+ 0.26%)}	_435,873k	_436,231k	_{p=0.005 n=6}
_{Parse Time}	_{3.31s (± 0.65%)}	_{3.30s (± 0.80%)}	_~	_3.27s	_3.33s	_{p=1.000 n=6}
_{Bind Time}	_{1.46s (± 0.28%)}	_{1.46s (± 0.28%)}	_~	_1.46s	_1.47s	_{p=0.218 n=6}
_{Check Time}	_{15.26s (± 0.45%)}	_{15.54s (± 0.34%)}	_{+0.28s (+ 1.81%)}	_15.48s	_15.61s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.03s (± 0.32%)}	_{20.30s (± 0.39%)}	_{+0.28s (+ 1.38%)}	_20.21s	_20.41s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,875k (± 0.02%)}	_{483,862k (± 0.01%)}	_~	_483,797k	_483,910k	_{p=0.936 n=6}
_{Parse Time}	_{3.36s (± 0.87%)}	_{3.37s (± 0.99%)}	_~	_3.32s	_3.42s	_{p=0.568 n=6}
_{Bind Time}	_{1.18s (± 1.84%)}	_{1.17s (± 0.89%)}	_~	_1.16s	_1.19s	_{p=0.806 n=6}
_{Check Time}	_{19.11s (± 0.09%)}	_{19.09s (± 0.24%)}	_~	_19.03s	_19.15s	_{p=0.570 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{23.65s (± 0.18%)}	_{23.64s (± 0.32%)}	_~	_23.52s	_23.73s	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-08T19:43:52Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60150/merge:

Something interesting changed - please have a look.

Details

actualbudget/actual

2 of 5 projects failed to build with the old tsc and were ignored

packages/loot-core/tsconfig.api.json

error TS2769: No overload matches this call.
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- packages/loot-core/src/server/encryption-internals.ts#L46
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'BufferSource'.
- packages/loot-core/src/server/encryption-internals.web.ts#L16
error TS2322: Type 'Buffer' is not assignable to type 'ArrayBuffer'.
- packages/loot-core/src/server/encryption-internals.web.ts#L40
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
- packages/loot-core/src/server/sync/encoder.ts#L55
- packages/loot-core/src/server/sync/encoder.ts#L56

angular/angular-cli

8 of 24 projects failed to build with the old tsc and were ignored

tests/legacy-cli/tsconfig.json

error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
- packages/angular_devkit/core/src/virtual-fs/host/buffer.ts#L13

apollographql/apollo-client

2 of 12 projects failed to build with the old tsc and were ignored

config/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'InputType'.
- config/bundlesize.ts#L9

blakeblackshear/frigate

web/tsconfig.json

error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'BufferSource'.
- web/src/components/player/MsePlayer.tsx#L326

Chocobozzz/PeerTube

6 of 12 projects failed to build with the old tsc and were ignored

packages/types-generator/tsconfig.types.json

error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'BinaryLike'.
- packages/node-utils/src/crypto.ts#L4 in packages/node-utils/tsconfig.json
- packages/node-utils/src/crypto.ts#L8 in packages/node-utils/tsconfig.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView | Stream | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView>'.
error TS2769: No overload matches this call.
- server/core/helpers/peertube-crypto.ts#L83 in server/tsconfig.types.json
- server/core/helpers/peertube-crypto.ts#L98 in server/tsconfig.types.json
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- server/core/lib/hls.ts#L163 in server/tsconfig.types.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
- server/core/lib/live/shared/muxing-session.ts#L476 in server/tsconfig.types.json
error TS2430: Interface 'Buffer' incorrectly extends interface 'Uint8Array<ArrayBufferLike>'.
- file:///mnt/ts_downloads/_/m/PeerTube/client/node_modules/@types/node/buffer.d.ts#L622 in client/tsconfig.types.json
error TS2344: Type 'Buffer' does not satisfy the constraint 'ArrayBufferView'.
- file:///mnt/ts_downloads/_/m/PeerTube/client/node_modules/@types/node/fs/promises.d.ts#L57 in client/tsconfig.types.json
- file:///mnt/ts_downloads/_/m/PeerTube/client/node_modules/@types/node/fs/promises.d.ts#L235 in client/tsconfig.types.json

packages/types-generator/tsconfig.json

error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'BinaryLike'.
- packages/node-utils/src/crypto.ts#L4 in packages/node-utils/tsconfig.json
- packages/node-utils/src/crypto.ts#L8 in packages/node-utils/tsconfig.json

packages/tests/tsconfig.json

error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'BinaryLike'.
- packages/node-utils/src/crypto.ts#L4 in packages/node-utils/tsconfig.json
- packages/node-utils/src/crypto.ts#L8 in packages/node-utils/tsconfig.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView | Stream | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView>'.
error TS2769: No overload matches this call.
- server/core/helpers/peertube-crypto.ts#L83 in server/tsconfig.lib.json
- server/core/helpers/peertube-crypto.ts#L98 in server/tsconfig.lib.json
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- server/core/lib/hls.ts#L163 in server/tsconfig.lib.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
- server/core/lib/live/shared/muxing-session.ts#L476 in server/tsconfig.lib.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- packages/tests/src/server-helpers/image.ts#L18 in packages/tests/tsconfig.json
- packages/tests/src/server-helpers/image.ts#L20 in packages/tests/tsconfig.json
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Stream | ArrayBufferView | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView>'.
- packages/tests/src/shared/import-export.ts#L75 in packages/tests/tsconfig.json
- packages/tests/src/shared/videos.ts#L442 in packages/tests/tsconfig.json

continuedev/continue

6 of 9 projects failed to build with the old tsc and were ignored

extensions/vscode/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- extensions/vscode/src/VsCodeIde.ts#L377
error TS2769: No overload matches this call.
- extensions/vscode/src/stubs/SecretStorage.ts#L45
- extensions/vscode/src/stubs/SecretStorage.ts#L74
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- extensions/vscode/src/stubs/SecretStorage.ts#L57
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- extensions/vscode/src/stubs/SecretStorage.ts#L79
- extensions/vscode/src/stubs/SecretStorage.ts#L82
error TS2322: Type 'Buffer & string' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- extensions/vscode/src/stubs/SecretStorage.ts#L82

typescript-bot · 2024-10-08T19:43:52Z

@jakebailey Here are some more interesting changes from running the top 400 repos suite

Details

Eugeny/tabby

11 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.main.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- app/lib/config.ts#L16
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- app/lib/utfSplitter.ts#L11
- app/lib/utfSplitter.ts#L11

app/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- app/lib/config.ts#L16
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- app/lib/utfSplitter.ts#L11
- app/lib/utfSplitter.ts#L11

FlowiseAI/Flowise

1 of 3 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.json

error TS2345: Argument of type 'RedisByteStore' is not assignable to parameter of type 'BaseStore<string, Uint8Array<ArrayBufferLike>>'.
- packages/components/nodes/cache/RedisCache/RedisEmbeddingsCache.ts#L133
error TS2769: No overload matches this call.
- packages/components/nodes/documentloaders/Pdf/Pdf.ts#L114
error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
- packages/components/nodes/documentloaders/S3Directory/S3Directory.ts#L202
- packages/components/nodes/documentloaders/S3File/S3File.ts#L522
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.

FuelLabs/fuels-ts

34 of 58 projects failed to build with the old tsc and were ignored

packages/crypto/tsconfig.dts.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- packages/crypto/src/node/aes-ctr.ts#L47
error TS2769: No overload matches this call.
- packages/crypto/src/node/aes-ctr.ts#L69
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BytesLike'.
- packages/crypto/src/node/hmac.ts#L11
- packages/crypto/src/node/pbkdf2.ts#L14

packages/abi-typegen/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BytesLike'.

packages/abi-typegen/tsconfig.dts.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BytesLike'.
- packages/abi-typegen/src/utils/collectBinFilePaths.ts#L24

gitpod-io/gitpod

12 of 20 projects failed to build with the old tsc and were ignored

components/gitpod-db/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BinaryLike'.
- components/gitpod-protocol/src/protocol.ts#L510

hexojs/hexo

tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView> | Stream'.
- lib/plugins/console/generate.ts#L109

homebridge/homebridge

tsconfig.json

error TS2345: Argument of type 'string | Buffer | TypedArray | DataView<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
- src/util/mac.ts#L13

honojs/hono

7 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBufferLike'.
error TS2345: Argument of type 'Promise<{ routePath: string; content: string; mimeType: string; } | { routePath: string; content: ArrayBuffer | SharedArrayBuffer; mimeType: string; }>' is not assignable to parameter of type 'Promise<{ routePath: string; content: string | ArrayBuffer; mimeType: string; } | undefined>'.
- src/helper/ssg/ssg.test.tsx#L400
- src/helper/ssg/ssg.test.tsx#L470
error TS2769: No overload matches this call.
error TS2345: Argument of type 'Uint8Array<ArrayBuffer>' is not assignable to parameter of type 'ArrayBufferLike'.
- src/middleware/secure-headers/secure-headers.ts#L131
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'BodyInit | null | undefined'.
- src/request.test.ts#L210
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer'.
- src/utils/buffer.test.ts#L100
- src/utils/buffer.test.ts#L115

typescript-bot · 2024-10-08T19:43:53Z

@jakebailey Here are some more interesting changes from running the top 400 repos suite

Details

jupyterlab/jupyterlab

46 of 59 projects failed to build with the old tsc and were ignored

packages/ui-components/examples/simple-windowed-list/tsconfig.json

error TS2430: Interface 'Buffer' incorrectly extends interface 'Uint8Array<ArrayBufferLike>'.
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/buffer.d.ts#L632 in packages/coreutils/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/buffer.d.ts#L632 in packages/statedb/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/buffer.d.ts#L632 in packages/services/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/buffer.d.ts#L632 in packages/ui-components/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/buffer.d.ts#L632 in packages/ui-components/examples/simple-windowed-list/tsconfig.json
error TS2344: Type 'Buffer' does not satisfy the constraint 'ArrayBufferView'.
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L56 in packages/coreutils/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L238 in packages/coreutils/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L56 in packages/statedb/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L238 in packages/statedb/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L56 in packages/services/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L238 in packages/services/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L56 in packages/ui-components/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L238 in packages/ui-components/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L56 in packages/ui-components/examples/simple-windowed-list/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/node_modules/@types/node/fs/promises.d.ts#L238 in packages/ui-components/examples/simple-windowed-list/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/statedb' or its corresponding type declarations.
- packages/settingregistry/src/settingregistry.ts#L4 in packages/settingregistry/tsconfig.json
- packages/settingregistry/src/tokens.ts#L7 in packages/settingregistry/tsconfig.json
- packages/services/src/setting/index.ts#L8 in packages/services/tsconfig.json
- packages/services/src/workspace/index.ts#L6 in packages/services/tsconfig.json
- packages/translation/src/tokens.ts#L8 in packages/translation/tsconfig.json
- packages/apputils/src/widgettracker.ts#L4 in packages/apputils/tsconfig.json
- packages/application/src/layoutrestorer.ts#L7 in packages/application/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/coreutils' or its corresponding type declarations.
- packages/services/src/builder/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/config/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/contents/index.ts#L6 in packages/services/tsconfig.json
- packages/services/src/event/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/kernel/default.ts#L4 in packages/services/tsconfig.json
- packages/services/src/kernel/restapi.ts#L5 in packages/services/tsconfig.json
- packages/services/src/kernelspec/restapi.ts#L7 in packages/services/tsconfig.json
- packages/services/src/nbconvert/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/serverconnection.ts#L4 in packages/services/tsconfig.json
- packages/services/src/session/restapi.ts#L6 in packages/services/tsconfig.json
- packages/services/src/session/session.ts#L12 in packages/services/tsconfig.json
- packages/services/src/setting/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/terminal/default.ts#L4 in packages/services/tsconfig.json
- packages/services/src/terminal/restapi.ts#L4 in packages/services/tsconfig.json
- packages/services/src/testutils.ts#L9 in packages/services/tsconfig.json
- packages/services/src/user/index.ts#L4 in packages/services/tsconfig.json
- packages/services/src/workspace/index.ts#L4 in packages/services/tsconfig.json
- packages/translation/src/server.ts#L4 in packages/translation/tsconfig.json
- packages/ui-components/src/components/switch.ts#L4 in packages/ui-components/tsconfig.json
- packages/ui-components/src/components/windowedlist.ts#L13 in packages/ui-components/tsconfig.json
- packages/ui-components/src/utils.ts#L4 in packages/ui-components/tsconfig.json
- packages/apputils/src/menufactory.ts#L6 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/thememanager.ts#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/tokens.ts#L4 in packages/apputils/tsconfig.json
- packages/codeeditor/src/editor.ts#L6 in packages/codeeditor/tsconfig.json
- packages/rendermime/src/registry.ts#L6 in packages/rendermime/tsconfig.json
- packages/rendermime/src/renderers.ts#L6 in packages/rendermime/tsconfig.json
- packages/docregistry/src/context.ts#L12 in packages/docregistry/tsconfig.json
- packages/docregistry/src/default.ts#L6 in packages/docregistry/tsconfig.json
- packages/docregistry/src/mimedocument.ts#L6 in packages/docregistry/tsconfig.json
- packages/docregistry/src/registry.ts#L9 in packages/docregistry/tsconfig.json
- packages/application/src/lab.ts#L4 in packages/application/tsconfig.json
- packages/application/src/router.ts#L6 in packages/application/tsconfig.json
- packages/ui-components/examples/simple-windowed-list/src/index.ts#L8 in packages/ui-components/examples/simple-windowed-list/tsconfig.json
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer'.
- packages/services/src/kernel/serialize.ts#L254 in packages/services/tsconfig.json
error TS2322: Type 'string | undefined' is not assignable to type 'string'.
- packages/services/src/serverconnection.ts#L273 in packages/services/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/settingregistry' or its corresponding type declarations.
- packages/services/src/setting/index.ts#L6 in packages/services/tsconfig.json
- packages/apputils/src/menufactory.ts#L7 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L12 in packages/apputils/tsconfig.json
- packages/apputils/src/thememanager.ts#L5 in packages/apputils/tsconfig.json
- packages/apputils/src/tokens.ts#L6 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L7 in packages/apputils/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/services' or its corresponding type declarations.
- packages/translation/src/manager.ts#L4 in packages/translation/tsconfig.json
- packages/translation/src/server.ts#L6 in packages/translation/tsconfig.json
- packages/translation/src/tokens.ts#L7 in packages/translation/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/printing.ts#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L10 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L11 in packages/apputils/tsconfig.json
- packages/apputils/src/testutils.ts#L6 in packages/apputils/tsconfig.json
- packages/rendermime/src/registry.ts#L8 in packages/rendermime/tsconfig.json
- packages/docregistry/src/context.ts#L19 in packages/docregistry/tsconfig.json
- packages/docregistry/src/default.ts#L8 in packages/docregistry/tsconfig.json
- packages/docregistry/src/registry.ts#L12 in packages/docregistry/tsconfig.json
- packages/docregistry/src/testutils.ts#L15 in packages/docregistry/tsconfig.json
- packages/application/src/connectionlost.ts#L5 in packages/application/tsconfig.json
- packages/application/src/frontend.ts#L6 in packages/application/tsconfig.json
- packages/application/src/lab.ts#L7 in packages/application/tsconfig.json
- packages/application/src/tokens.ts#L4 in packages/application/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/translation' or its corresponding type declarations.
- packages/ui-components/src/components/form.tsx#L6 in packages/ui-components/tsconfig.json
- packages/ui-components/src/components/sidepanel.ts#L8 in packages/ui-components/tsconfig.json
- packages/ui-components/src/components/toolbar.tsx#L11 in packages/ui-components/tsconfig.json
- packages/ui-components/src/icon/widgets/tabbarsvg.ts#L4 in packages/ui-components/tsconfig.json
- packages/apputils/src/dialog.tsx#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L10 in packages/apputils/tsconfig.json
- packages/apputils/src/mainareawidget.ts#L4 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L15 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L17 in packages/apputils/tsconfig.json
- packages/apputils/src/thememanager.ts#L10 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L8 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/widget.tsx#L8 in packages/apputils/tsconfig.json
- packages/codeeditor/src/editor.ts#L8 in packages/codeeditor/tsconfig.json
- packages/codeeditor/src/jsoneditor.ts#L10 in packages/codeeditor/tsconfig.json
- packages/codeeditor/src/lineCol.tsx#L9 in packages/codeeditor/tsconfig.json
- packages/rendermime/src/registry.ts#L9 in packages/rendermime/tsconfig.json
- packages/rendermime/src/renderers.ts#L8 in packages/rendermime/tsconfig.json
- packages/rendermime/src/tokens.ts#L7 in packages/rendermime/tsconfig.json
- packages/rendermime/src/widgets.ts#L6 in packages/rendermime/tsconfig.json
- packages/docregistry/src/components.tsx#L7 in packages/docregistry/tsconfig.json
- packages/docregistry/src/context.ts#L24 in packages/docregistry/tsconfig.json
- packages/docregistry/src/default.ts#L10 in packages/docregistry/tsconfig.json
- packages/docregistry/src/mimedocument.ts#L16 in packages/docregistry/tsconfig.json
- packages/docregistry/src/registry.ts#L14 in packages/docregistry/tsconfig.json
- packages/application/src/connectionlost.ts#L6 in packages/application/tsconfig.json
- packages/application/src/mimerenderers.ts#L12 in packages/application/tsconfig.json
- packages/application/src/shell.ts#L5 in packages/application/tsconfig.json
- packages/application/src/tokens.ts#L5 in packages/application/tsconfig.json
- packages/application/src/utils.ts#L7 in packages/application/tsconfig.json
- packages/theme-light-extension/src/index.ts#L13 in packages/theme-light-extension/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/ui-components' or its corresponding type declarations.
- packages/statusbar/src/components/hover.tsx#L4 in packages/statusbar/tsconfig.json
- packages/apputils/src/commandpalette.ts#L6 in packages/apputils/tsconfig.json
- packages/apputils/src/dialog.tsx#L11 in packages/apputils/tsconfig.json
- packages/apputils/src/index.ts#L7 in packages/apputils/tsconfig.json
- packages/apputils/src/index.ts#L33 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L11 in packages/apputils/tsconfig.json
- packages/apputils/src/mainareawidget.ts#L5 in packages/apputils/tsconfig.json
- packages/apputils/src/menufactory.ts#L8 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L21 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L9 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/registry.ts#L10 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/widget.tsx#L20 in packages/apputils/tsconfig.json
- packages/codeeditor/src/jsoneditor.ts#L11 in packages/codeeditor/tsconfig.json
- packages/codeeditor/src/lineCol.tsx#L16 in packages/codeeditor/tsconfig.json
- packages/docregistry/src/registry.ts#L30 in packages/docregistry/tsconfig.json
- packages/application/src/frontend.ts#L7 in packages/application/tsconfig.json
- packages/application/src/mimerenderers.ts#L13 in packages/application/tsconfig.json
- packages/application/src/shell.ts#L14 in packages/application/tsconfig.json
- packages/ui-components/examples/simple-windowed-list/src/index.ts#L18 in packages/ui-components/examples/simple-windowed-list/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/statusbar' or its corresponding type declarations.
- packages/apputils/src/kernelstatuses.tsx#L5 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L23 in packages/apputils/tsconfig.json
- packages/codeeditor/src/lineCol.tsx#L4 in packages/codeeditor/tsconfig.json
error TS2339: Property 'addClass' does not exist on type 'KernelStatus'.
- packages/apputils/src/kernelstatuses.tsx#L123 in packages/apputils/tsconfig.json
error TS2339: Property 'model' does not exist on type 'KernelStatus'.
- packages/apputils/src/kernelstatuses.tsx#L130 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L135 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L136 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L137 in packages/apputils/tsconfig.json
error TS2339: Property 'stateChanged' does not exist on type 'Model'.
- packages/apputils/src/kernelstatuses.tsx#L194 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L236 in packages/apputils/tsconfig.json
- packages/apputils/src/kernelstatuses.tsx#L260 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L204 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L219 in packages/apputils/tsconfig.json
- packages/codeeditor/src/lineCol.tsx#L398 in packages/codeeditor/tsconfig.json
error TS7006: Parameter 'item' implicitly has an 'any' type.
- packages/apputils/src/menufactory.ts#L81 in packages/apputils/tsconfig.json
- packages/apputils/src/menufactory.ts#L83 in packages/apputils/tsconfig.json
error TS7006: Parameter 'a' implicitly has an 'any' type.
- packages/apputils/src/menufactory.ts#L82 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L112 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L143 in packages/apputils/tsconfig.json
error TS7006: Parameter 'b' implicitly has an 'any' type.
- packages/apputils/src/menufactory.ts#L82 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L112 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L143 in packages/apputils/tsconfig.json
error TS7006: Parameter 'entry' implicitly has an 'any' type.
- packages/apputils/src/menufactory.ts#L169 in packages/apputils/tsconfig.json
error TS2339: Property 'addClass' does not exist on type 'RunningSessions'.
- packages/apputils/src/runningSessions.tsx#L115 in packages/apputils/tsconfig.json
error TS2339: Property 'model' does not exist on type 'RunningSessions'.
- packages/apputils/src/runningSessions.tsx#L122 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L129 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L130 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L134 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L135 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L165 in packages/apputils/tsconfig.json
- packages/apputils/src/runningSessions.tsx#L175 in packages/apputils/tsconfig.json
error TS2339: Property 'title' does not exist on type 'RunningSessions'.
- packages/apputils/src/runningSessions.tsx#L127 in packages/apputils/tsconfig.json
error TS7006: Parameter 'reason' implicitly has an 'any' type.
- packages/apputils/src/sessioncontext.tsx#L671 in packages/apputils/tsconfig.json
error TS18046: 'item' is of type 'unknown'.
- packages/apputils/src/sessioncontext.tsx#L827 in packages/apputils/tsconfig.json
error TS18046: 'session' is of type 'unknown'.
- packages/apputils/src/sessioncontext.tsx#L1602 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1603 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1609 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1609 in packages/apputils/tsconfig.json
error TS18046: 'sessions' is of type 'unknown'.
- packages/apputils/src/sessioncontext.tsx#L1609 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1644 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1729 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1761 in packages/apputils/tsconfig.json
error TS18046: 'kernel' is of type 'unknown'.
- packages/apputils/src/sessioncontext.tsx#L1728 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1729 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1731 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1760 in packages/apputils/tsconfig.json
- packages/apputils/src/sessioncontext.tsx#L1761 in packages/apputils/tsconfig.json
error TS7006: Parameter 'settings' implicitly has an 'any' type.
- packages/apputils/src/thememanager.ts#L46 in packages/apputils/tsconfig.json
error TS7006: Parameter 'plugin' implicitly has an 'any' type.
- packages/apputils/src/toolbar/factory.ts#L120 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L152 in packages/apputils/tsconfig.json
- packages/apputils/src/toolbar/factory.ts#L205 in packages/apputils/tsconfig.json
error TS7006: Parameter 'sender' implicitly has an 'any' type.
- packages/apputils/src/toolbar/factory.ts#L205 in packages/apputils/tsconfig.json
- [packages/application/src/mimerenderers.ts#L155](https://github.com/
  :error: Truncated - see log for full output :error:

typescript-bot · 2024-10-08T19:43:53Z

@jakebailey Here are some more interesting changes from running the top 400 repos suite

Details

lerna/lerna

1 of 42 projects failed to build with the old tsc and were ignored

tools/scripts/tsconfig.scripts.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- tools/scripts/lerna-release.ts#L144

tools/scripts/tsconfig.e2e.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- tools/scripts/lerna-release.ts#L144

microsoft/vscode

5 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2345: Argument of type 'string | Buffer | Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
- src/bootstrap-fork.ts#L134
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'string | Buffer | Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'string | ArrayBufferView'.
- src/vs/base/node/pfs.ts#L404
- src/vs/base/node/pfs.ts#L414
error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- src/vs/base/node/pfs.ts#L445
- src/vs/base/node/pfs.ts#L454
error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
- src/vs/editor/browser/gpu/objectCollectionBuffer.ts#L114
- src/vs/editor/browser/gpu/objectCollectionBuffer.ts#L160
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer | Uint32Array<ArrayBufferLike>'.
- src/vs/editor/common/tokens/contiguousTokensStore.ts#L82
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BinaryLike'.
- src/vs/server/node/webClientServer.ts#L438
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer'.
- src/vs/workbench/api/common/extHostWebviewMessaging.ts#L40
error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- src/vs/workbench/services/textMate/browser/backgroundTokenization/threadedBackgroundTokenizerFactory.ts#L155

src/tsconfig.monaco.json

error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
- src/vs/editor/browser/gpu/objectCollectionBuffer.ts#L114
- src/vs/editor/browser/gpu/objectCollectionBuffer.ts#L160
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer | Uint32Array<ArrayBufferLike>'.
- src/vs/editor/common/tokens/contiguousTokensStore.ts#L82

extensions/vscode-test-resolver/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- extensions/vscode-test-resolver/src/extension.ts#L217
error TS2769: No overload matches this call.
- extensions/vscode-test-resolver/src/extension.ts#L272
- extensions/vscode-test-resolver/src/extension.ts#L279

extensions/vscode-api-tests/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataTransferFile | undefined'.
- extensions/vscode-api-tests/src/singlefolder-tests/workspace.test.ts#L1235

extensions/typescript-language-features/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- extensions/typescript-language-features/src/tsServer/serverProcess.electron.ts#L48
- extensions/typescript-language-features/src/tsServer/serverProcess.electron.ts#L48

extensions/tunnel-forwarding/tsconfig.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- extensions/tunnel-forwarding/src/split.ts#L26
- extensions/tunnel-forwarding/src/split.ts#L26

extensions/ipynb/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.

extensions/html-language-features/client/tsconfig.json

error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- extensions/html-language-features/client/src/customData.ts#L57

extensions/git/tsconfig.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- extensions/git/src/fileSystemProvider.ts#L193
error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BinaryLike'.
- extensions/git/src/ipc/ipcServer.ts#L37

extensions/emmet/tsconfig.json

error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
- extensions/emmet/src/imageSizeHelper.ts#L78

extensions/debug-auto-launch/tsconfig.json

error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
- extensions/debug-auto-launch/src/extension.ts#L261
error TS2769: No overload matches this call.
- extensions/debug-auto-launch/src/extension.ts#L263
- extensions/debug-auto-launch/src/extension.ts#L265

extensions/css-language-features/client/tsconfig.json

error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- extensions/css-language-features/client/src/requests.ts#L28

build/tsconfig.build.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BinaryLike'.
error TS2769: No overload matches this call.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- build/darwin/verify-macho.ts#L27
- build/linux/debian/install-sysroot.ts#L54
error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
- build/lib/asar.ts#L150
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- build/lib/builtInExtensionsCG.ts#L51
error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- build/lib/standalone.ts#L29
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | Uint8Array<ArrayBufferLike>'.
- build/lib/tsb/transpiler.ts#L347
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- build/lib/util.ts#L275
- build/lib/util.ts#L275

neoclide/coc.nvim

tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.

nexe/nexe

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- src/compiler.ts#L167
error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
- src/compiler.ts#L325
- src/compiler.ts#L325
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string | ArrayBufferView'.
- src/fs/SnapshotZipFS.ts#L188
- src/fs/SnapshotZipFS.ts#L230
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'ArrayBufferView'.
- src/fs/patch.ts#L38

omnivore-app/omnivore

5 of 22 projects failed to build with the old tsc and were ignored

packages/rss-handler/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BinaryLike'.
- packages/rss-handler/src/index.ts#L149

openai-translator/openai-translator

tsconfig.json

error TS2322: Type 'ArrayBufferLike' is not assignable to type 'BlobPart'.
- src/common/components/Translator.tsx#L1289

peers/peerjs

tsconfig.json

error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- lib/dataconnection/BufferedConnection/BinaryPack.ts#L31
- lib/dataconnection/BufferedConnection/Json.ts#L36
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer'.
- lib/dataconnection/BufferedConnection/BinaryPack.ts#L94
- lib/dataconnection/BufferedConnection/BinaryPack.ts#L98

puppeteer/puppeteer

7 of 14 projects failed to build with the old tsc and were ignored

packages/testserver/tsconfig.json

error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'InputType'.
- packages/testserver/src/index.ts#L309 in packages/testserver/tsconfig.json

redis/node-redis

6 of 8 projects failed to build with the old tsc and were ignored

packages/client/tsconfig.json

error TS2345: Argument of type 'Buffer[]' is not assignable to parameter of type 'readonly Uint8Array<ArrayBufferLike>[]'.
- packages/client/lib/client/RESP2/composers/buffer.ts#L12
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
error TS2769: No overload matches this call.
- packages/client/lib/client/socket.ts#L250

socketio/socket.io

12 of 30 projects failed to build with the old tsc and were ignored

packages/engine.io/tsconfig.json

error TS2769: No overload matches this call.
- packages/engine.io/lib/server.ts#L802
error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string | ArrayBuffer | SharedArrayBuffer | ArrayBufferView'.
- packages/engine.io/lib/transports/polling.ts#L150

subquery/subql

4 of 6 projects failed to build with the old tsc and were ignored

packages/query/tsconfig.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.

Tonejs/Tone.js

tsconfig.json

error TS2345: Argument of type 'Float32Array<ArrayBuffer>' is not assignable to parameter of type 'ArrayBuffer'.
- Tone/core/context/DummyContext.test.ts#L25

uuidjs/uuid

tsconfig.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- src/test/v35.test.ts#L46
- src/test/v35.test.ts#L52
error TS2345: Argument of type '(bytes: Uint8Array<ArrayBufferLike>) => Buffer' is not assignable to parameter of type 'HashFunction'.
- src/v3.ts#L20
- src/v5.ts#L20
error TS2322: Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBuffer>'.
- src/v35.ts#L48

tsconfig.cjs.json

error TS2322: Type 'Buffer' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'Uint8Array<ArrayBufferLike>'.
- src/test/v35.test.ts#L46
- src/test/v35.test.ts#L52
error TS2345: Argument of type '(bytes: Uint8Array<ArrayBufferLike>) => Buffer' is not assignable to parameter of type 'HashFunction'.
- src/v3.ts#L20
- src/v5.ts#L20
error TS2322: Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBuffer>'.
- src/v35.ts#L48

video-dev/hls.js

tsconfig.json

error TS2322: Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBuffer'.
- src/controller/audio-stream-controller.ts#L248
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer'.
error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- src/controller/eme-controller.ts#L349
- src/demux/transmuxer.ts#L251
error TS2345: Argument of type 'Uint8Array<ArrayBufferLike> | null' is not assignable to parameter of type 'ArrayBuffer | null'.
- src/controller/eme-controller.ts#L454
error TS2322: Type 'Uint8Array<ArrayBuffer> | null' is not assignable to type 'ArrayBuffer | null'.
- src/controller/eme-controller.ts#L732
error TS2345: Argument of type 'ArrayBuffer | Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'ArrayBuffer'.
- src/controller/timeline-controller.ts#L582
error TS2345: Argument of type 'ArrayBufferLike' is not assignable to parameter of type 'ArrayBuffer | PromiseLike<ArrayBuffer>'.
- src/crypt/decrypter.ts#L92
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer | null'.
- src/crypt/decrypter.ts#L144
error TS2322: Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
- src/crypt/decrypter.ts#L198
error TS2345: Argument of type 'ArrayBuffer | SharedArrayBuffer' is not assignable to parameter of type 'ArrayBuffer | Uint8Array<ArrayBufferLike>'.
- src/demux/sample-aes.ts#L59
error TS2769: No overload matches this call.
- src/demux/sample-aes.ts#L116
- src/remux/mp4-generator.ts#L410
error TS2322: Type 'Uint8Array<ArrayBufferLike> | null' is not assignable to type 'ArrayBuffer | null'.
- src/demux/transmuxer.ts#L138
error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'string | ArrayBuffer'.
error TS2345: Argument of type 'Uint8Array<ArrayBuffer>' is not assignable to parameter of type 'ArrayBuffer'.
- tests/unit/demuxer/transmuxer.ts#L235

VSCodeVim/Vim

tsconfig.json

error TS2345: Argument of type 'Uint8Array<ArrayBuffer>' is not assignable to parameter of type 'ArrayBuffer'.
- src/vimscript/expression/evaluate.ts#L439
- src/vimscript/expression/parser.ts#L49
error TS2322: Type 'Uint8Array<ArrayBuffer>' is not assignable to type 'ArrayBuffer'.

petamoriken · 2024-10-09T03:37:46Z

I haven't figured it out yet, but maybe we need to update the Buffer type in @types/node.

petamoriken · 2024-10-10T06:46:13Z

Apparently the package maintainers need to update @types/node.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-beta/#typedarrays-are-now-generic-over-arraybufferlike

FYI: #58573 (comment)

petamoriken · 2024-11-04T15:53:51Z

src/harness/vfsUtil.ts

-    /**
-     * Read from a file.
-     *
-     * NOTE: do not rename this method as it is intended to align with the same named export of the "fs" module.
-     */
-    public readFileSync(path: string, encoding?: null): Buffer; // eslint-disable-line no-restricted-syntax


I deleted this type because CI failed, but it might be better to revert it.

petamoriken · 2024-11-19T17:25:44Z

@rbuckton IMO, this PR should be included in TypeScript 5.7, but is it possible?

rbuckton · 2024-11-19T17:26:45Z

No, this will need to wait for 5.8

Use string literal type in ArrayBuffer's Symbol.toStringTag

1f52275

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 6, 2024

fix

f90cb73

jakebailey mentioned this pull request Oct 14, 2024

Use a literal string for ArrayBuffer's toStringTag #60227

Closed

petamoriken commented Nov 4, 2024

View reviewed changes

Merge branch 'main' into fix/arraybuffer-tostringtag

b46ff93

typescript-bot assigned rbuckton Jan 22, 2025

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 22, 2025

Fix to use string literal type in ArrayBuffer's Symbol.toStringTag #60150

Are you sure you want to change the base?

Fix to use string literal type in ArrayBuffer's Symbol.toStringTag #60150

Conversation

petamoriken commented Oct 6, 2024

jakebailey commented Oct 8, 2024

typescript-bot commented Oct 8, 2024 • edited Loading

typescript-bot commented Oct 8, 2024

/mnt/ts_downloads/_/m/pyright/build.sh

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

tsc

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

typescript-bot commented Oct 8, 2024

petamoriken commented Oct 9, 2024

petamoriken commented Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

petamoriken commented Nov 19, 2024

rbuckton commented Nov 19, 2024

Fix to use string literal type in ArrayBuffer's `Symbol.toStringTag` #60150

Fix to use string literal type in ArrayBuffer's `Symbol.toStringTag` #60150

typescript-bot commented Oct 8, 2024 •

edited

Loading

petamoriken commented Oct 10, 2024 •

edited

Loading