TRPC 11 #41

vafanassieff · 2024-05-07T12:46:42Z

Hey there, thanks for this package.
We took few liberties to improve the DX / testing

Closes #37

Best

🎯 Changes

changed repo structure to a monorepo with pnpm
use trpc@next since it's a release candidate
new handler generation (from @louneskmt)
use links like a normal TRPC client (from @louneskmt)
use vitest as test runner
add tests for node and react

✅ Checklist

If necessary, I have added documentation related to the changes made.
I have added or updated the tests related to the changes made.

packages/msw-trpc/package.json

packages/msw-trpc/src/create.ts

l0gicgate · 2024-06-17T02:42:16Z

packages/test-react/package.json

+    "@trpc/server": "11.0.0-rc.403",
+    "@types/react": "18.3.3",
+    "@types/react-dom": "18.3.0",
+    "jsdom": "24.1.0",


happy-dom is faster than jsdom, albeit it is lacking some of the web APIs, one should consider trying to see if it's adequate for this package

https://github.com/capricorn86/happy-dom

I chose jsdom because they support Websocket in the browser without needing a polyfill. Tests packages are only here for example, you can use happy-dom too.

l0gicgate

@vafanassieff I've reviewed the entire PR, it looks great. I am not a core contributor though but I am looking forward to seeing this merged as we are using tRPC v11 and would like to use this package for testing.

Co-authored-by: Pierre B. <[email protected]>

vafanassieff · 2024-06-17T08:08:34Z

@vafanassieff I've reviewed the entire PR, it looks great. I am not a core contributor though but I am looking forward to seeing this merged as we are using tRPC v11 and would like to use this package for testing.

Thanks !
The PR is just missing an updated documentation, we changed the API and added the Websocket API.
And msw websocket is still in beta.

packages/msw-trpc/src/handler.ts

maloguertin · 2024-08-09T13:18:01Z

@vafanassieff could you add the documentation and then we could go forward with this PR? Thanks!

randseay · 2024-09-05T19:21:29Z

Our team is excited to see support for tRPC v11, thank you! Is there a chance this might merge soon?

vafanassieff · 2024-09-06T06:52:03Z

@vafanassieff could you add the documentation and then we could go forward with this PR? Thanks!

Hey I currently don't have much time to write the docs, if someone want to chat with me and @louneskmt to have some guidance and help us!

jasonsilvers-dispel · 2024-09-11T20:29:04Z

@vafanassieff @louneskmt I would be happy to help with the documentation. The github action to publish might also need to be updated as well. I ran into a few issues with it when creating a temporary fork.

vafanassieff · 2024-09-14T23:13:38Z

Hey, I removed the websocket part since it added too much overhead for almost nothing.
We can add this later, I think HTTP link is enough for a first release.
The doc is updated, it's pretty straightforward, use msw-trpc like a regular tRPC client.

rinarakaki · 2024-10-29T09:52:37Z

@vafanassieff could you please resolve the conflicts?

I think we need to pnpm install before pnpm prettier in the workflow. And there seems still some code to be fixed.

Run pnpm prettier --check .
Checking formatting...
[warn] packages/msw-trpc/src/handler.ts
[warn] packages/msw-trpc/src/links.ts
[warn] pnpm-lock.yaml
[warn] Code style issues found in 3 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

I made a PR to fix this vafanassieff#2. Please squash merge it.

rinarakaki · 2024-10-29T11:35:47Z

@maloguertin could you please take a look at the doc update?

rinarakaki · 2024-10-30T02:08:42Z

README.md

 ## Config

-`createTRPCMsw` accepts a 2nd argument:
+You need to pass a `httpLink` to the `createTRPCMsw` function like you would do with the tRPC client.


This description must come before the **2. build your trpcMsw with createTRPCMsw.** in the ## Usage section above since the config argument of createTRPCMsw is now non-optional.

* Update npm-publish.yml * Update npm-publish.yml * Update npm-publish.yml * Update test.yml * update * update * update

danilofuchs · 2024-11-06T14:56:32Z

@maloguertin msw has released WebSocket support in version 2.6.0

https://github.com/mswjs/msw/releases/tag/v2.6.0

I love this package and have been using it extensively with @vafanassieff fork

Is there anything else the community is able to provide in this PR to unblock it and start implementing WebSocket, FormData and other goodies?

vafanassieff · 2024-11-06T15:46:38Z

@maloguertin msw has released WebSocket support in version 2.6.0

https://github.com/mswjs/msw/releases/tag/v2.6.0

I love this package and have been using it extensively with @vafanassieff fork

Is there anything else the community is able to provide in this PR to unblock it and start implementing WebSocket, FormData and other goodies?

If you look in the previous commit, we added a way to use websocket, but it was kinda cluncky and out of the scope of this PR.

(BTW we moved to SSE instead of websocket for subscriptions, it's much easier)

Mathieu-R · 2024-12-12T07:46:46Z

Hi !
I'm currently using it in a project and this fork works just fine (at least for now) with TRPC v11 and MSW v2.

Any plan to merge ? @vafanassieff Did you publish your fork on npm under a prefix ?

vafanassieff · 2024-12-12T09:31:25Z

Hi ! I'm currently using it in a project and this fork works just fine (at least for now) with TRPC v11 and MSW v2.

Any plan to merge ? @vafanassieff Did you publish your fork on npm under a prefix ?

I'm using "@vafanassieff/msw-trpc": "0.0.1" meanwhile.

vafanassieff and others added 10 commits April 29, 2024 19:35

feat: use trpc 11

57d17d7

feat: use vitest insted of jest

f8ea88f

feat: add test on pull request workflow

e83de84

feat: pending websocket support

b208162

chore: refactor tests

ef5ded9

feat: handlers based on links + working websocket

6620c16

feat: add trigger for subscriptions

092d04b

feat: allow subscriptions that only send data on trigger

7280a19

feat: monorepo

cc68134

feat: add react tests

8312450

vafanassieff mentioned this pull request May 7, 2024

TRPC 11 and Vitest #40

Closed

2 tasks

vafanassieff added 3 commits May 8, 2024 20:57

chore: update dependencies

e8889a3

chore: update workflows

841fbce

chore: update dependencies and add more react tests

77a0057

vafanassieff force-pushed the ws branch from d669a8f to 77a0057 Compare May 15, 2024 13:23

vafanassieff marked this pull request as ready for review May 27, 2024 09:49

vafanassieff added 4 commits May 30, 2024 05:38

feat: ensure subscription is started

758780c

chore: update dependencies

2dc0c7e

chore: clean names

f95687a

chore: update trpc

09abe7d

l0gicgate reviewed Jun 17, 2024

View reviewed changes

packages/msw-trpc/package.json Outdated Show resolved Hide resolved

l0gicgate reviewed Jun 17, 2024

View reviewed changes

packages/msw-trpc/src/create.ts Show resolved Hide resolved

l0gicgate reviewed Jun 17, 2024

View reviewed changes

l0gicgate approved these changes Jun 17, 2024

View reviewed changes

chore: tRPC not Trpc

855debc

Co-authored-by: Pierre B. <[email protected]>

vafanassieff mentioned this pull request Jun 17, 2024

Support for V11 #37

Open

kenny-grubb reviewed Jul 31, 2024

View reviewed changes

packages/msw-trpc/src/handler.ts Show resolved Hide resolved

vafanassieff added 2 commits September 15, 2024 01:05

refactor: remove websocket

1fd41ea

chore: update docs

a21703e

This comment was marked as resolved.

Sign in to view

rinarakaki reviewed Oct 30, 2024

View reviewed changes

fix (#2)

482efd1

* Update npm-publish.yml * Update npm-publish.yml * Update npm-publish.yml * Update test.yml * update * update * update

rikukissa mentioned this pull request Jan 17, 2025

Add storybook testing setup for client opencrvs/opencrvs-core#8335

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRPC 11 #41

TRPC 11 #41

vafanassieff commented May 7, 2024 •

edited

Loading

l0gicgate Jun 17, 2024

vafanassieff Jun 17, 2024 •

edited

Loading

l0gicgate left a comment •

edited

Loading

vafanassieff commented Jun 17, 2024

maloguertin commented Aug 9, 2024

randseay commented Sep 5, 2024

vafanassieff commented Sep 6, 2024

jasonsilvers-dispel commented Sep 11, 2024 •

edited

Loading

vafanassieff commented Sep 14, 2024

This comment was marked as resolved.

rinarakaki commented Oct 29, 2024 •

edited

Loading

rinarakaki commented Oct 29, 2024

rinarakaki Oct 30, 2024

danilofuchs commented Nov 6, 2024

vafanassieff commented Nov 6, 2024

Mathieu-R commented Dec 12, 2024

vafanassieff commented Dec 12, 2024

TRPC 11 #41

Are you sure you want to change the base?

TRPC 11 #41

Conversation

vafanassieff commented May 7, 2024 • edited Loading

🎯 Changes

✅ Checklist

l0gicgate Jun 17, 2024

Choose a reason for hiding this comment

vafanassieff Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

l0gicgate left a comment • edited Loading

Choose a reason for hiding this comment

vafanassieff commented Jun 17, 2024

maloguertin commented Aug 9, 2024

randseay commented Sep 5, 2024

vafanassieff commented Sep 6, 2024

jasonsilvers-dispel commented Sep 11, 2024 • edited Loading

vafanassieff commented Sep 14, 2024

This comment was marked as resolved.

rinarakaki commented Oct 29, 2024 • edited Loading

rinarakaki commented Oct 29, 2024

rinarakaki Oct 30, 2024

Choose a reason for hiding this comment

danilofuchs commented Nov 6, 2024

vafanassieff commented Nov 6, 2024

Mathieu-R commented Dec 12, 2024

vafanassieff commented Dec 12, 2024

vafanassieff commented May 7, 2024 •

edited

Loading

vafanassieff Jun 17, 2024 •

edited

Loading

l0gicgate left a comment •

edited

Loading

jasonsilvers-dispel commented Sep 11, 2024 •

edited

Loading

rinarakaki commented Oct 29, 2024 •

edited

Loading