TRPC 11 and Vitest #40
Closed
+1,979
−4,186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vafanassieff
force-pushed
the
main
branch
2 times, most recently
from
a951088 to
67a5db8
Compare
Open
vafanassieff
force-pushed
the
main
branch
4 times, most recently
from
638c3f7 to
2708154
Compare
|
That's solid work! At first glance everything seems good. I'll set myself a reminder to finish the review next week. Thanks you! |
|
@maloguertin Thanks, we are working on a better version with subscription support it's still WIP, i will mark this PR a draft until we have it |
|
Closed in favor of #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for this package.
All current tests are passing
@maloguertin is this okay for you ?
I updated all the package.
I'm importing
defaultTransformerfrom@trpc/server/unstable-core-do-not-importmaybe it's not the best thing to do.It could be nice to merge #30 after to have a correct React example.
Closes #37
I have no idea yet how to handle subscription tho
Best
🎯 Changes
trpc@nextsince it's a release candidatevitestas test runner (can make another PR for this)✅ Checklist