Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4.1 timer #42

Merged
merged 18 commits into from
Feb 19, 2025
Merged

V4.1 timer #42

merged 18 commits into from
Feb 19, 2025
+415 −144

Conversation

jakemcivor
Copy link
Member

No description provided.

@jakemcivor
Update LSTimer.h
71cbea7 
-Fix interval timer running every loop
- Add commenting
@jakemcivor
Update timer
16ffc2c 
Integrate timer
@jakemcivor
Copy link
Member Author

Things to fix to integrate (fixed) timers into 4.1 code:

  1. Adjusting poll timers to match previous version
  2. Fixing Bluetooth no-connection blink
  3. Check full calibration

jakemcivor and others added 14 commits February 12, 2025 10:35
@jakemcivor
Update LSConfig.h
1870e05 
Clarify action mapping
@jversloot
Update timing variables
557cee4
@jversloot
Merge branch 'v4.1-timer' of https://github.com/makersmakingchange/Li…
bbeabf9 
…pSync into v4.1-timer
@jakemcivor
Update LSTimer.h
f576da1 
Add comments for main timer loop
@jakemcivor
Merge branch 'v4.1-timer' of https://github.com/makersmakingchange/Li…
52b0640 
…pSync into v4.1-timer
@jakemcivor
Revert "Merge branch 'v4.1-timer' of https://github.com/makersmakingc…
e9cc593 
…hange/LipSync into v4.1-timer"

This reverts commit 52b0640, reversing
changes made to f576da1.
@jakemcivor
Update LSTimer.h
5bf8959 
Re-add new timer code.
@jversloot
Update timing variables
530e918
@jakemcivor
Fix lighting.
42659d2 
Put numRuns++ before function call in timer, since some functions use that to determine operation.
@jversloot
Update LSScreen.h
89c128b 
Updated hardcoded values with named constants
@jversloot
Update LSTimer.h
cc627f7 
Fix bug where timers were not deleting after running a set number of times
@jversloot
Fixed bug with timers not incrementing properly
ae28008 
Moved where timers were being incremented so they would run the correct number of times and then delete the timer. Also reformatted the switch case to a shorter if statement.
@jversloot
Update LSPressure.h
7e82c32 
Added small delay to allow sip and puff to work more consistently on startup
@jversloot
Update LSConfig.h
5334d48 
Clean up comments
@jversloot
Copy link
Contributor

In mouse "click" function (both USB and BT), should a delay be added between button press and release? Currently, a mouse report is sent to press the button and then immediately to release it. Check if this causes clicks to not always be registered, such as middle click.

@jversloot jversloot linked an issue Feb 18, 2025 that may be closed by this pull request
LipSync Hub Menu Hangs / doesn't register on short button press #39
Open
jversloot
jversloot approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@jversloot jversloot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes timer delays, causing poll speed to be affected by defined poll delays. Seems to maintain performance with current poll speeds.

@jversloot jversloot linked an issue Feb 19, 2025 that may be closed by this pull request
Timers created via setInterval function not working correctly #40
Open
@jakemcivor
Update LSConfig.h
b839a45
@jakemcivor
Update LSTimer.h
597952d 
Variable cleanup and commenting
@jakemcivor jakemcivor merged commit 76a7948 into v4.1 Feb 19, 2025
@jakemcivor jakemcivor deleted the v4.1-timer branch February 19, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jversloot jversloot jversloot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jakemcivor @jversloot