Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Hardening Guide Section on Authentication Mechanisms #42486
Kubernetes Hardening Guide Section on Authentication Mechanisms #42486
Changes from all commits
1e7a4eb
3dd0bd1
0761ef8
076c879
8ed2edd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page doesn't taste like a concept page.
Maybe it should be a reference page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a reference either. Actual guides really belong in the tasks section. I think that'd be a good home
We could invent a new
content_type
:guide
. If that feels useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm not hugely attached to where this ends up, what I would say is that it's a slightly funny one. The content in tasks feels quite hands-on (i.e. specific commands that are being run) where this is higher level.
Not to say we couldn't put it in tasks, but it's not a 100% fit there, compared to other content in that section. That said, I'd agree isn't not 100% concept either :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since tasks are for "contains pages that show how to do individual tasks", I don't feel this hardening guide on auth mechanisms belong there unless we extend the scope of the tasks section to include a new content_type of guide
Good practices for Kubernetes Secrets
and Role Based Access Control Good Practices are under concepts. I would consider these as guides as well.
There is a Best Practices section, https://kubernetes.io/docs/setup/best-practices/. Is a hardening guide (& other guides) a good fit for the Best Practices section -- I'm leaning towards yes but I can also see this not under best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenID Connect (OIDC)