-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Hardening Guide Section on Authentication Mechanisms #42486
Conversation
…ication Mechanisms
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Show resolved
Hide resolved
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really liked it, very clear and concise. I agree with sftim's comments, just not sure we need to go into TLS version recommendation details.
/lgtm
LGTM label has been added. Git tree hash: 42c9696677089bab7462e74397a8f079f4d1b858
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Outdated
Show resolved
Hide resolved
LGTM label has been added. Git tree hash: 0dbe68c46082213a48080b88630c24d4fbc692e7
|
…on-mechanisms.md Co-authored-by: Tim Bannister <[email protected]>
@@ -0,0 +1,143 @@ | |||
--- | |||
title: Hardening Guide - Authentication Mechanisms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page doesn't taste like a concept page.
Maybe it should be a reference page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a reference either. Actual guides really belong in the tasks section. I think that'd be a good home
We could invent a new content_type
: guide
. If that feels useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm not hugely attached to where this ends up, what I would say is that it's a slightly funny one. The content in tasks feels quite hands-on (i.e. specific commands that are being run) where this is higher level.
Not to say we couldn't put it in tasks, but it's not a 100% fit there, compared to other content in that section. That said, I'd agree isn't not 100% concept either :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since tasks are for "contains pages that show how to do individual tasks", I don't feel this hardening guide on auth mechanisms belong there unless we extend the scope of the tasks section to include a new content_type of guide
Good practices for Kubernetes Secrets
and Role Based Access Control Good Practices are under concepts. I would consider these as guides as well.
There is a Best Practices section, https://kubernetes.io/docs/setup/best-practices/. Is a hardening guide (& other guides) a good fit for the Best Practices section -- I'm leaning towards yes but I can also see this not under best practices.
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/hardening-guide/authentication-mechanisms.md
Outdated
Show resolved
Hide resolved
…on-mechanisms.md Co-authored-by: Qiming Teng <[email protected]>
Following up #42486 (comment) If we want to make a new section for, eg If we do decide to do that, I'm OK to plan for it but also find an interim home for this PR's changes to land, and then refactor. We could add a note for localizers to make the situation clear. |
configured authentication source. | ||
|
||
For production clusters with multiple users directly accessing the Kubernetes API, it is | ||
recommended to use external authentication sources such as OIDC. The internal authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenID Connect (OIDC)
/lgtm |
LGTM label has been added. Git tree hash: 0b978a37273f6f9e1855c68470b5645ea9241134
|
I'm good to have this land under concepts for now. Like Tim mentioned earlier, if we make a new section for |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the first section for the Kubernetes hardening guide which has been under discussion in SIG-Security-Docs kubernetes/sig-security#30 .