-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang: Build 1.24rc1 images #3872
base: master
Are you sure you want to change the base?
Conversation
This seems like a legitimate failure, but let's retest just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, but let's see what's going on with the test.
/lgtm
/approve
the issue is
will see how to fix that for k8s-ci-builder that runs go <= 1.22 |
/test pull-release-image-k8s-ci-builder |
Signed-off-by: cpanato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
/hold
/assign @ameukam @Verolop @puerco @MadhavJivrajani
cc @kubernetes/release-managers @liggitt
Which issue(s) this PR fixes:
xref #3772
Special notes for your reviewer:
Does this PR introduce a user-facing change?