Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GO_VERSION_TOOLING to be able to build the release tooling with another go version #3874

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 30, 2024

What type of PR is this?

/kind feature

/hold

Our K/Release repo is using Go1.23 and when we need to build the images/releng/k8s-ci-builder for older k/k release branches, like release-1.30 that uses go1.22 the image build fails because it needs Go1.23

 > [builder 4/4] RUN ./compile-release-tools:
#6 0.079 Setting up environment...
#6 0.084 Compiling default release tools...
#6 0.086 fatal: not a git repository (or any of the parent directories): .git
#6 0.091 go: go.mod requires go >= 1.23.3 (running go 1.22.9; GOTOOLCHAIN=local)

the proposed fix is to compile the release tooling with the Go needed and not be attached tot he Go that is used in k/k

Currently is breaking the updates, as we can see in #3872 / #3873

/assign @saschagrunert @Verolop @xmudrii

What this PR does / why we need it:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add GO_VERSION_TOOLING to be able to build the release tooling with another go version

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2024
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato force-pushed the add-GO_VERSION_TOOLING branch from 6f19ebf to 987773f Compare December 30, 2024 16:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2024
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Jan 8, 2025

i will move this forward

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 91e4b59 into kubernetes:master Jan 8, 2025
12 checks passed
@cpanato cpanato deleted the add-GO_VERSION_TOOLING branch January 8, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants