Add custom thresholds mechanism in APIResponsivenessPrometheus measurement #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/scalability
mm4tt
reviewed
May 27, 2020
clusterloader2/pkg/measurement/common/slos/api_responsiveness_prometheus.go
Outdated
Show resolved
Hide resolved
clusterloader2/pkg/measurement/common/slos/api_responsiveness_prometheus.go
Outdated
Show resolved
Hide resolved
tosi3k
force-pushed
the
cl2-custom-thresholds
branch
from
7a5c7ba to
9d389eb
Compare
Done. |
mm4tt
reviewed
May 27, 2020
clusterloader2/pkg/measurement/common/slos/api_responsiveness_prometheus.go
Outdated
Show resolved
Hide resolved
tosi3k
force-pushed
the
cl2-custom-thresholds
branch
from
9d389eb to
34de156
Compare
k8s-ci-robot
added
size/L
Done. I don't know why I assumed writing legit unit tests for the custom thresholds is going to take much more effort than it actually did. |
tosi3k
force-pushed
the
cl2-custom-thresholds
branch
from
34de156 to
52e17e7
Compare
tosi3k
commented
May 28, 2020
clusterloader2/pkg/measurement/common/slos/api_responsiveness_prometheus_test.go
Outdated
Show resolved
Hide resolved
tosi3k
force-pushed
the
cl2-custom-thresholds
branch
from
52e17e7 to
f1d338d
Compare
|
/lgtm Nice! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To automatize Golang regression detection in our CI jobs it'd be convenient to override the default SLO threshold for certain metrics.
Custom thresholds included in the
custom_api_call_thresholds.yamlfile derive from experiments with running a kubemark load test job with the faulty golang version./sig scalability
/cc mm4tt