Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Add custom thresholds mechanism in APIResponsivenessPrometheus measurement #1524

Merged
merged 1 commit into from
Oct 7, 2020
Merged

[1.18] Add custom thresholds mechanism in APIResponsivenessPrometheus measurement #1524

merged 1 commit into from
Oct 7, 2020

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Oct 7, 2020

Cherry-pick #1276 to 1.18

Needed to cherry-pick other improvements of this measurement.

/cc @wojtek-t
/cc @tosi3k

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Oct 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2020
@tosi3k
Copy link
Member

tosi3k commented Oct 7, 2020

@jkaniuk I think you need to change measurement.Config occurrences in the code to measurement.MeasurementConfig as the name of the interface was changed in release-1.19.

@jkaniuk jkaniuk force-pushed the custom-thresholds-18 branch from 35a8e2e to 8090bf2 Compare October 7, 2020 08:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2020
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Oct 7, 2020

@jkaniuk I think you need to change measurement.Config occurrences in the code to measurement.MeasurementConfig as the name of the interface was changed in release-1.19.

Right, done

@tosi3k
Copy link
Member

tosi3k commented Oct 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1bd8fee into kubernetes:release-1.18 Oct 7, 2020
@marseel marseel mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosi3k tosi3k Awaiting requested review from tosi3k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkaniuk @wojtek-t @tosi3k @k8s-ci-robot