direct node access logs/portforward/exec/attach via kubelet debug interface

[XciD]

Adding support for kubelet debug handlers as described in #1425

These methods require a kubelet-debug feature flag.

[clux]

thanks a lot. this largely looks good to me, just a few nits on testing, top level interface and docs.

[clux]

some minor nits and questions, stuff is looking very good though

[clux]

Btw, are you testing this with k3d locally? I tried it against my cluster and i can't get it to work out of the box and the port stuff needs a node filter:

INFO[0000] portmapping '10250:10250' lacks a nodefilter, but there's more than one node: defaulting to [servers:*:proxy agents:*:proxy]
FATA[0000] K3sExtraArg '--kube-apiserver-arg=feature-gates=WatchList=true' lacks a node filter, but there's more than one node

[XciD]

Btw, are you testing this with k3d locally? I tried it against my cluster and i can't get it to work out of the box and the port stuff needs a node filter:

INFO[0000] portmapping '10250:10250' lacks a nodefilter, but there's more than one node: defaulting to [servers:*:proxy agents:*:proxy]
FATA[0000] K3sExtraArg '--kube-apiserver-arg=feature-gates=WatchList=true' lacks a node filter, but there's more than one node

I've tested with a simple command: k3d cluster create -p 10250:10250, which command are you using ?

[clux]

Ah. It was my own command misuse.

(It seems that possibly --no-lb does not work well with -p -possibly k3d-io/k3d#380. it's normally not a blocking warning but it seems to get elevated when using certain api args.. works without that flag)

At any rate, I have now tried your example and it works 👍

[clux]

put some example comments for the type of documentation, feel free to take it verbatim. i am likely out most of tomorrow, but can fixup whatever things remain after that.

[codecov]

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 72.2%. Comparing base (8df88ce) to head (a56235a).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #1428     +/-   ##
=======================================
+ Coverage   72.1%   72.2%   +0.1%     
=======================================
  Files         75      78      +3     
  Lines       6470    6546     +76     
=======================================
+ Hits        4663    4722     +59     
- Misses      1807    1824     +17     

Files	Coverage Δ
kube-client/src/api/subresource.rs	44.0% <ø> (ø)
kube-client/src/client/builder.rs	59.0% <ø> (ø)
kube-client/src/client/mod.rs	72.2% <ø> (+0.3%)	⬆️
kube-client/src/lib.rs	75.2% <ø> (ø)
kube-core/src/subresource.rs	78.5% <100.0%> (ø)
kube-client/src/client/kubelet_debug.rs	0.0% <0.0%> (ø)
kube-core/src/kubelet_debug.rs	0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

[clux]

Went through the pr and tried to clean up the documentation a bit further. I have a commit you can cherry-pick at 237e78d if you are happy with it.
Did a few extra renames and stuff to try to more clearly disambiguate.

Then i am happy to send this through :-)

[XciD]

Went through the pr and tried to clean up the documentation a bit further. I have a commit you can cherry-pick at 237e78d if you are happy with it. Did a few extra renames and stuff to try to more clearly disambiguate.

Then i am happy to send this through :-)

LGTM :) thank you !

[XciD]

🙏

BTW, don't know if you saw, we sponsored you because your library is really cool. Great job !

[clux]

Ah, I assumed that might have been parts of your doing. Thanks a lot! 🙇

Feel free to add yourselves to kube.rs/adopters when/if you feel comfortable with that.

and thanks again for the PRs!