Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct node2 #1434

Closed
wants to merge 13 commits into from
Closed

Direct node2 #1434

wants to merge 13 commits into from

Conversation

clux
Copy link
Member

@clux clux commented Mar 22, 2024

addendums to #1428

XciD and others added 13 commits March 21, 2024 13:51
@XciD
feat: direct node access logs/portforward/exec/attach
13b3a11 
Signed-off-by: Adrien <[email protected]>
@XciD
remove doc as it's not compiling
517a395 
Signed-off-by: Adrien <[email protected]>
@XciD
add k3d 10250 kubelet port
dae085e 
Signed-off-by: Adrien <[email protected]>
@XciD
Add new example: pod_log_node_proxy + pr comments
3c84ee6 
Signed-off-by: Adrien <[email protected]>
@XciD
revert unwanted change
c14feff 
Signed-off-by: Adrien <[email protected]>
@XciD
fix ci
266e78c 
Signed-off-by: Adrien <[email protected]>
@XciD
add in coverage too
c7207c3 
Signed-off-by: Adrien <[email protected]>
@XciD
pr comments
6f92fd0 
Signed-off-by: Adrien <[email protected]>
@XciD
last fix
10aa932 
Signed-off-by: Adrien <[email protected]>
@XciD
fix typo on feature flag
a5443e3 
Signed-off-by: Adrien <[email protected]>
@XciD
fix examples
02ad7f3 
Signed-off-by: Adrien <[email protected]>
@clux
documentation fixes, renames and caveats to kubelet interface
237e78d 
since it shows up in `Client::` impls it should have caveats.
have linked to alternatives, prefixed the names with kubelet_
(which is a little redundant, but it helps here).

also documented and split up a few related things i found with just doc.

Signed-off-by: clux <[email protected]>
@clux
Merge branch 'main' into direct-node2
48d3d0a
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 72.2%. Comparing base (8df88ce) to head (48d3d0a).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1434     +/-   ##
=======================================
+ Coverage   72.1%   72.2%   +0.1%     
=======================================
  Files         75      78      +3     
  Lines       6470    6546     +76     
=======================================
+ Hits        4663    4722     +59     
- Misses      1807    1824     +17
Files Coverage Δ
kube-client/src/api/subresource.rs 44.0% <ø> (ø)
kube-client/src/client/builder.rs 59.0% <ø> (ø)
kube-client/src/client/mod.rs 72.2% <ø> (+0.3%) ⬆️
kube-client/src/lib.rs 75.2% <ø> (ø)
kube-core/src/subresource.rs 78.5% <100.0%> (ø)
kube-client/src/client/kubelet_debug.rs 0.0% <0.0%> (ø)
kube-core/src/kubelet_debug.rs 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

@clux clux closed this Mar 22, 2024
@clux clux deleted the direct-node2 branch March 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clux @XciD