Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure CNCF GA4 website measurement ID #504

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Configure CNCF GA4 website measurement ID #504

merged 1 commit into from
Feb 26, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 26, 2025 •
edited
Loading

  • Fixes CNCF Google Analytics #502
  • Adds the CNCF-owned GA4 ID to the website config
  • If you prefer adding Admin access to your existing measurement ID, let me know.

Related:

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kcl-lang-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 7:38am

He1pa
He1pa approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa merged commit dcffaa1 into kcl-lang:main Feb 26, 2025
4 of 7 checks passed
@chalin chalin deleted the patch-1 branch February 26, 2025 07:10
@chalin
Copy link
Contributor Author

chalin commented Feb 26, 2025

FYI, I've not had a lot of success with configuring multiple IDs in the past, but let's hope it works here. If not, we'll try something else.

@He1pa
Copy link
Contributor

He1pa commented Feb 26, 2025

FYI, I've not had a lot of success with configuring multiple IDs in the past, but let's hope it works here. If not, we'll try something else.

If multiple IDs are not supported, do we need to remove the original Google Analysis ID?

@chalin chalin mentioned this pull request Feb 26, 2025
Closed
@chalin chalin mentioned this pull request Feb 26, 2025
Open
30 tasks
@chalin
Copy link
Contributor Author

chalin commented Feb 26, 2025

If multiple IDs are not supported, do we need to remove the original Google Analysis ID?

Let's continue the discussion via #502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNCF Google Analytics
2 participants
@chalin @He1pa