Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose metrics of karmada-metrics-adapter #6013

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Jan 2, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

expose metrics of karmada-metrics-adapter

Which issue(s) this PR fixes:

Fixes part of #5954

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-metrics-adapter`: Introduced `--metrics-bind-address` flag which will be used to expose Prometheus metrics.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 2, 2025
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 2, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 48.37%. Comparing base (a891673) to head (c7009b2).

Files with missing lines Patch % Lines
cmd/metrics-adapter/app/options/options.go 0.00% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6013      +/-   ##
==========================================
- Coverage   48.39%   48.37%   -0.03%     
==========================================
  Files         665      665              
  Lines       54811    54836      +25     
==========================================
  Hits        26525    26525              
- Misses      26568    26593      +25     
  Partials     1718     1718              
Flag Coverage Δ
unittests 48.37% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@RainbowMango
Copy link
Member

Have you tested it? Could you please share the test report?

@RainbowMango
Copy link
Member

Release notes:

`karmada-metrics-adapter`: Introduced `--metrics-bind-address` flag which will be used to expose Prometheus metrics.

@RainbowMango RainbowMango added this to the v1.13 milestone Jan 3, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@chaosi-zju
Copy link
Member Author

Have you tested it? Could you please share the test report?

Yes, I tested for all four installation method

you can see test result in check metrics of metris-adapter step of the following ci task:

local up: https://github.com/chaosi-zju/karmada/actions/runs/12591245687/job/35094180733
helm: https://github.com/chaosi-zju/karmada/actions/runs/12591245693/job/35094072631

as for karmadactl and operator, I tested manually.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I see. Thanks.
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@karmada-bot karmada-bot merged commit 72b6bd7 into karmada-io:master Jan 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants