-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose metrics of karmada-metrics-adapter #6013
Conversation
Signed-off-by: chaosi-zju <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6013 +/- ##
==========================================
- Coverage 48.39% 48.37% -0.03%
==========================================
Files 665 665
Lines 54811 54836 +25
==========================================
Hits 26525 26525
- Misses 26568 26593 +25
Partials 1718 1718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Have you tested it? Could you please share the test report? |
Release notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Yes, I tested for all four installation method you can see test result in local up: https://github.com/chaosi-zju/karmada/actions/runs/12591245687/job/35094180733 as for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I see. Thanks.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
expose metrics of karmada-metrics-adapter
Which issue(s) this PR fixes:
Fixes part of #5954
Special notes for your reviewer:
Does this PR introduce a user-facing change?: